Changeset 44451 for trunk/src/wp-admin/includes/update.php

Timestamp:

01/08/2019 03:28:15 AM (8 years ago)

Author:

pento

Message:

Install/Upgrade: Link to HelpHub instead of the Codex.

WordPress version links in the Codex (eg, ​https://codex.wordpress.org/Version_5.0) are redirected to their HelpHub equivalent.

Rather than relying on the redirect, Core and link directly to HelpHub.

Props swissspidy.
Fixes #45574.

File:

• trunk/src/wp-admin/includes/update.php (modified) (2 diffs)

trunk/src/wp-admin/includes/update.php

@@ -263 +263 @@
         }
 
+        $version_url = sprintf(
+                /* translators: %s: WordPress version */
+                esc_url( __( 'https://wordpress.org/support/wordpress-version/version-%s/' ) ),
+                sanitize_title( $cur->current )
+        );
+
         if ( current_user_can( 'update_core' ) ) {
                 $msg = sprintf(
-                        /* translators: 1: Codex URL to release notes, 2: new WordPress version, 3: URL to network admin, 4: accessibility text */
+                        /* translators: 1: URL to WordPress release notes, 2: new WordPress version, 3: URL to network admin, 4: accessibility text */
                         __( '<a href="%1$s">WordPress %2$s</a> is available! <a href="%3$s" aria-label="%4$s">Please update now</a>.' ),
-                        sprintf(
-                                /* translators: %s: WordPress version */
-                                esc_url( __( 'https://codex.wordpress.org/Version_%s' ) ),
-                                $cur->current
-                        ),
+                        $version_url,
                         $cur->current,
                         network_admin_url( 'update-core.php' ),
@@ -278 +280 @@
         } else {
                 $msg = sprintf(
-                        /* translators: 1: Codex URL to release notes, 2: new WordPress version */
+                        /* translators: 1: URL to WordPress release notes, 2: new WordPress version */
                         __( '<a href="%1$s">WordPress %2$s</a> is available! Please notify the site administrator.' ),
-                        sprintf(
-                                /* translators: %s: WordPress version */
-                                esc_url( __( 'https://codex.wordpress.org/Version_%s' ) ),
-                                $cur->current
-                        ),
+                        $version_url,
                         $cur->current
                 );