Changeset 44452 for trunk/tests/phpunit/tests/post/query.php

Timestamp:

01/08/2019 03:32:04 AM (6 years ago)

Author:

boonebgorges

Message:

Query: Standardize treatment of 'orderby' values post__in, post_parent__in, and post_name__in.

Ordering by post__in was introduced in [21776], but the code assumed that
post__in would be a comma-separated string listing post IDs. When an array
of post IDs was passed to the post__in query var, 'orderby=postin' was
not respected. This changeset changes this behavior by handling
'orderby=postin' in the same way as most other values of 'orderby',
which ensures that arrays as well as strings can be properly parsed.

The same treatment is given to the similar post_name__in and
post_parent__in options of 'orderby', so that most query generation for
orderby clauses happens in the same place, instead of in special cases.

A slight change in the resulting SQL (related to the whitespace around
parentheses and commas) necessitates a change to an existing REST API test
that does a string comparison against the SQL query.

Props mgibbs189, kelvink.
Fixes #38034.

File:

• trunk/tests/phpunit/tests/post/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/post/query.php

@@ -172 +172 @@
             )
         );
+        $this->assertSame( $ordered, wp_list_pluck( $q->posts, 'ID' ) );
+    }
+
+    /**
+     * @ticket 38034
+     */
+    public function test_orderby_post__in_array() {
+        $posts = self::factory()->post->create_many( 4 );
+
+        $ordered = array( $posts[2], $posts[0], $posts[3] );
+
+        $q = new WP_Query( array(
+            'post_type' => 'any',
+            'post__in' => $ordered,
+            'orderby' => array( 'post__in' => 'ASC' ),
+        ) );
+        $this->assertSame( $ordered, wp_list_pluck( $q->posts, 'ID' ) );
+    }
+
+    /**
+     * @ticket 38034
+     */
+    public function test_orderby_post__in_array_with_implied_order() {
+        $posts = self::factory()->post->create_many( 4 );
+
+        $ordered = array( $posts[2], $posts[0], $posts[3] );
+
+        $q = new WP_Query( array(
+            'post_type' => 'any',
+            'post__in' => $ordered,
+            'orderby' => 'post__in',
+        ) );
         $this->assertSame( $ordered, wp_list_pluck( $q->posts, 'ID' ) );
     }