Changeset 44510

Timestamp:

01/09/2019 10:30:49 AM (6 years ago)

Author:

pento

Message:

Tests: Improve REST API tests for categories and tags.

Props birgire, SergeyBiryukov.
See #39122.
Fixes #45077.

Location:

trunk/tests/phpunit/tests/rest-api

Files:

• rest-categories-controller.php (modified) (3 diffs)
• rest-tags-controller.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-categories-controller.php

@@ -691 +691 @@
     }
 
+    /**
+     * @ticket 39122
+     */
     public function test_get_item_meta() {
         $request  = new WP_REST_Request( 'GET', '/wp/v2/categories/1' );
@@ -699 +702 @@
         $meta = (array) $data['meta'];
         $this->assertArrayHasKey( 'test_single', $meta );
-        $this->assertEquals( $meta['test_single'], '' );
+        $this->assertSame( $meta['test_single'], '' );
         $this->assertArrayHasKey( 'test_multi', $meta );
-        $this->assertEquals( $meta['test_multi'], array() );
+        $this->assertSame( $meta['test_multi'], array() );
         $this->assertArrayHasKey( 'test_cat_single', $meta );
-        $this->assertEquals( $meta['test_cat_single'], '' );
+        $this->assertSame( $meta['test_cat_single'], '' );
         $this->assertArrayHasKey( 'test_cat_multi', $meta );
-        $this->assertEquals( $meta['test_cat_multi'], array() );
-    }
-
+        $this->assertSame( $meta['test_cat_multi'], array() );
+    }
+
+    /**
+     * @ticket 39122
+     */
     public function test_get_item_meta_registered_for_different_taxonomy() {
         $request  = new WP_REST_Request( 'GET', '/wp/v2/categories/1' );
@@ -713 +719 @@
         $data     = $response->get_data();
         $this->assertArrayHasKey( 'meta', $data );
-        $this->assertArrayHasKey( 'meta', $data );
 
         $meta = (array) $data['meta'];
-        $this->assertEquals( false, isset( $meta['test_tag_meta'] ) );
+        $this->assertFalse( isset( $meta['test_tag_meta'] ) );
     }
 

trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

@@ -630 +630 @@
     }
 
+    /**
+     * @ticket 39122
+     */
     public function test_get_item_meta() {
         $id       = $this->factory->tag->create();
@@ -639 +642 @@
         $meta = (array) $data['meta'];
         $this->assertArrayHasKey( 'test_single', $meta );
-        $this->assertEquals( $meta['test_single'], '' );
+        $this->assertSame( $meta['test_single'], '' );
         $this->assertArrayHasKey( 'test_multi', $meta );
-        $this->assertEquals( $meta['test_multi'], array() );
+        $this->assertSame( $meta['test_multi'], array() );
         $this->assertArrayHasKey( 'test_tag_single', $meta );
-        $this->assertEquals( $meta['test_tag_single'], '' );
+        $this->assertSame( $meta['test_tag_single'], '' );
         $this->assertArrayHasKey( 'test_tag_multi', $meta );
-        $this->assertEquals( $meta['test_tag_multi'], array() );
-    }
-
+        $this->assertSame( $meta['test_tag_multi'], array() );
+    }
+
+    /**
+     * @ticket 39122
+     */
     public function test_get_item_meta_registered_for_different_taxonomy() {
         $id       = $this->factory->tag->create();
@@ -656 +662 @@
 
         $meta = (array) $data['meta'];
-        $this->assertEquals( false, isset( $meta['test_cat_meta'] ) );
+        $this->assertFalse( isset( $meta['test_cat_meta'] ) );
     }