Changeset 44524 for trunk/src/wp-admin/themes.php

Timestamp:

01/09/2019 08:04:55 PM (6 years ago)

Author:

flixos90

Message:

Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard.

This changeset introduces a WP_Shutdown_Handler class that detects fatal errors and which extension (plugin or theme) causes them. Such an error is then recorded, and an error message is displayed. Subsequently, in certain protected areas, for example the admin, the broken extension will be paused, ensuring that the website is still usable in the respective area. The major benefit is that this mechanism allows site owners to still log in to their website, to fix the problem by either disabling the extension or solving the bug and then resuming the extension.

Extensions are only paused in certain designated areas. The frontend for example stays unaffected, as it is impossible to know what pausing the extension would cause to be missing, so it might be preferrable to clearly see that the website is temporarily not accessible instead.

The fatal error recovery is especially important in scope of encouraging the switch to a maintained PHP version, as not necessarily every WordPress extension is compatible with all PHP versions. If problems occur now, non-technical site owners that do not have immediate access to the codebase are not locked out of their site and can at least temporarily solve the problem quickly.

Websites that have custom requirements in that regard can implement their own shutdown handler by adding a shutdown-handler.php drop-in that returns the handler instance to use, which must be based on a class that inherits WP_Shutdown_Handler. That handler will then be used in place of the default one.

Websites that would like to modify specifically the error template displayed in the frontend can add a php-error.php drop-in that works similarly to the existing db-error.php drop-in.

Props afragen, bradleyt, flixos90, ocean90, schlessera, SergeyBiryukov, spacedmonkey.
Fixes #44458.

File:

• trunk/src/wp-admin/themes.php (modified) (5 diffs)

trunk/src/wp-admin/themes.php

@@ -33 +33 @@
         switch_theme( $theme->get_stylesheet() );
         wp_redirect( admin_url( 'themes.php?activated=true' ) );
+        exit;
+    } elseif ( 'resume' === $_GET['action'] ) {
+        check_admin_referer( 'resume-theme_' . $_GET['stylesheet'] );
+        $theme = wp_get_theme( $_GET['stylesheet'] );
+
+        if ( ! current_user_can( 'resume_themes' ) ) {
+            wp_die(
+                '<h1>' . __( 'You need a higher level of permission.' ) . '</h1>' .
+                '<p>' . __( 'Sorry, you are not allowed to resume this theme.' ) . '</p>',
+                403
+            );
+        }
+
+        $result = resume_theme( $theme->get_stylesheet() );
+
+        if ( is_wp_error( $result ) ) {
+            wp_die( $result );
+        }
+
+        wp_redirect( admin_url( 'themes.php?resumed=true' ) );
         exit;
     } elseif ( 'delete' == $_GET['action'] ) {
@@ -174 +194 @@
     <hr class="wp-header-end">
 <?php
-if ( ! validate_current_theme() || isset( $_GET['broken'] ) ) :
+if ( ! validate_current_theme() || isset( $_GET['broken'] ) ) {
     ?>
-<div id="message1" class="updated notice is-dismissible"><p><?php _e( 'The active theme is broken. Reverting to the default theme.' ); ?></p></div>
+    <div id="message1" class="updated notice is-dismissible"><p><?php _e( 'The active theme is broken. Reverting to the default theme.' ); ?></p></div>
     <?php
-elseif ( isset( $_GET['activated'] ) ) :
+} elseif ( isset( $_GET['activated'] ) ) {
     if ( isset( $_GET['previewed'] ) ) {
         ?>
         <div id="message2" class="updated notice is-dismissible"><p><?php _e( 'Settings saved and theme activated.' ); ?> <a href="<?php echo home_url( '/' ); ?>"><?php _e( 'Visit site' ); ?></a></p></div>
-        <?php } else { ?>
-<div id="message2" class="updated notice is-dismissible"><p><?php _e( 'New theme activated.' ); ?> <a href="<?php echo home_url( '/' ); ?>"><?php _e( 'Visit site' ); ?></a></p></div>
-                                                                        <?php
-}
-    elseif ( isset( $_GET['deleted'] ) ) :
+        <?php
+    } else {
         ?>
-<div id="message3" class="updated notice is-dismissible"><p><?php _e( 'Theme deleted.' ); ?></p></div>
-<?php elseif ( isset( $_GET['delete-active-child'] ) ) : ?>
+        <div id="message2" class="updated notice is-dismissible"><p><?php _e( 'New theme activated.' ); ?> <a href="<?php echo home_url( '/' ); ?>"><?php _e( 'Visit site' ); ?></a></p></div>
+        <?php
+    }
+} elseif ( isset( $_GET['deleted'] ) ) {
+    ?>
+    <div id="message3" class="updated notice is-dismissible"><p><?php _e( 'Theme deleted.' ); ?></p></div>
+    <?php
+} elseif ( isset( $_GET['delete-active-child'] ) ) {
+    ?>
     <div id="message4" class="error"><p><?php _e( 'You cannot delete a theme while it has an active child theme.' ); ?></p></div>
     <?php
-endif;
+} elseif ( isset( $_GET['resumed'] ) ) {
+    ?>
+    <div id="message5" class="updated notice is-dismissible"><p><?php _e( 'Theme resumed.' ); ?></p></div>
+    <?php
+}
 
 $ct = wp_get_theme();
@@ -345 +373 @@
 
     <?php
+    $can_resume  = current_user_can( 'resume_themes' );
     $can_delete  = current_user_can( 'delete_themes' );
     $can_install = current_user_can( 'install_themes' );
@@ -352 +381 @@
         <th><?php _ex( 'Name', 'theme name' ); ?></th>
         <th><?php _e( 'Description' ); ?></th>
+        <?php if ( $can_resume ) { ?>
+            <td></td>
+        <?php } ?>
         <?php if ( $can_delete ) { ?>
             <td></td>
@@ -364 +396 @@
             <td><?php echo $broken_theme->errors()->get_error_message(); ?></td>
             <?php
+            if ( $can_resume ) {
+                if ( 'theme_paused' === $broken_theme->errors()->get_error_code() ) {
+                    $stylesheet = $broken_theme->get_stylesheet();
+                    $resume_url = add_query_arg(
+                        array(
+                            'action'     => 'resume',
+                            'stylesheet' => urlencode( $stylesheet ),
+                        ),
+                        admin_url( 'themes.php' )
+                    );
+                    $resume_url = wp_nonce_url( $resume_url, 'resume-theme_' . $stylesheet );
+                    ?>
+                    <td><a href="<?php echo esc_url( $resume_url ); ?>" class="button resume-theme"><?php _e( 'Resume' ); ?></a></td>
+                    <?php
+                } else {
+                    ?>
+                    <td></td>
+                    <?php
+                }
+            }
+
             if ( $can_delete ) {
                 $stylesheet = $broken_theme->get_stylesheet();