Changeset 44528

Timestamp:

01/10/2019 01:31:52 AM (6 years ago)

Author:

desrosj

Message:

Media: Store audio creation date in meta.

In [41746], wp_get_media_creation_timestamp() was introduced to read the created timestamp for videos from getID3 in meta whenever possible. This information is useful separately from the dates on the file itself.

This adds the same support audio files by utilizing wp_get_media_creation_timestamp() in wp_read_audio_metadata().

Props blob folio, desrosj.
Fixes #42017.

Location:

trunk

Files:

• src/wp-admin/includes/media.php (modified) (2 diffs)
• tests/phpunit/tests/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -3341 +3341 @@
 
 /**
- * Retrieve metadata from a audio file's ID3 tags
+ * Retrieve metadata from an audio file's ID3 tags.
  *
  * @since 3.6.0
@@ -3383 +3383 @@
     if ( ! empty( $data['playtime_string'] ) ) {
         $metadata['length_formatted'] = $data['playtime_string'];
+    }
+
+    if ( empty( $metadata['created_timestamp'] ) ) {
+        $created_timestamp = wp_get_media_creation_timestamp( $data );
+
+        if ( false !==  $created_timestamp ) {
+            $metadata['created_timestamp'] = $created_timestamp;
+        }
     }
 

trunk/tests/phpunit/tests/media.php

@@ -2345 +2345 @@
 
     /**
+     * Test created timestamp is properly read from an MP4 file.
+     *
+     * This MP4 video file has an AAC audio track, so it can be used to test
+     *`wp_read_audio_metadata()`.
+     *
+     * @ticket 42017
+     */
+    function test_wp_read_audio_metadata_adds_creation_date_with_mp4() {
+        $video    = DIR_TESTDATA . '/uploads/small-video.mp4';
+        $metadata = wp_read_audio_metadata( $video );
+
+        $this->assertEquals( 1269120551, $metadata['created_timestamp'] );
+    }
+
+    /**
      * @ticket 35218
      */