Changeset 44539

Timestamp:

01/10/2019 02:56:24 AM (5 years ago)

Author:

pento

Message:

Admin: Don't use the keyup event in addition to the input event.

The keyup event was used to provide support for IE8, where which doesn't support the input event. As we dropped IE8 support some time ago, this was simply adding unnecessary complexity and double-event triggers.

Props dlh, afercia.
Fixes #32882.

Location:

trunk/src/js/_enqueues

Files:

• admin/user-profile.js (modified) (5 diffs)
• lib/nav-menu.js (modified) (2 diffs)
• wp/customize/nav-menus.js (modified) (1 diff)
• wp/customize/widgets.js (modified) (1 diff)

trunk/src/js/_enqueues/admin/user-profile.js

@@ -18 +18 @@
         $submitButtons,
         $submitButton,
-        currentPass,
-        inputEvent;
-
-    /*
-     * Use feature detection to determine whether password inputs should use
-     * the `keyup` or `input` event. Input is preferred but lacks support
-     * in legacy browsers.
-     */
-    if ( 'oninput' in document.createElement( 'input' ) ) {
-        inputEvent = 'input';
-    } else {
-        inputEvent = 'keyup';
-    }
+        currentPass;
 
     function generatePassword() {
@@ -72 +60 @@
             .data( 'pw', $pass1.data( 'pw' ) )
             .val( $pass1.val() )
-            .on( inputEvent, function () {
+            .on( 'input', function () {
                 if ( $pass1Text.val() === currentPass ) {
                     return;
@@ -87 +75 @@
         }
 
-        $pass1.on( inputEvent + ' pwupdate', function () {
+        $pass1.on( 'input' + ' pwupdate', function () {
             if ( $pass1.val() === currentPass ) {
                 return;
@@ -189 +177 @@
          * pass2 field to the pass1 field, then running check_pass_strength.
          */
-        $pass2 = $('#pass2').on( inputEvent, function () {
+        $pass2 = $( '#pass2' ).on( 'input', function () {
             if ( $pass2.val().length > 0 ) {
                 $pass1.val( $pass2.val() );
@@ -337 +325 @@
             greeting     = $( '#wp-admin-bar-my-account' ).find( '.display-name' );
 
-        $('#pass1').val('').on( inputEvent + ' pwupdate', check_pass_strength );
+        $( '#pass1' ).val( '' ).on( 'input' + ' pwupdate', check_pass_strength );
         $('#pass-strength-result').show();
         $('.color-palette').click( function() {

trunk/src/js/_enqueues/lib/nav-menu.js

@@ -874 +874 @@
 
         attachQuickSearchListeners : function() {
-            var searchTimer,
-                inputEvent;
+            var searchTimer;
 
             // Prevent form submission.
@@ -882 +881 @@
             });
 
-            /*
-             * Use feature detection to determine whether inputs should use
-             * the `keyup` or `input` event. Input is preferred but lacks support
-             * in legacy browsers. See changeset 34078, see also ticket #26600#comment:59
-             */
-            if ( 'oninput' in document.createElement( 'input' ) ) {
-                inputEvent = 'input';
-            } else {
-                inputEvent = 'keyup';
-            }
-
-            $( '#nav-menu-meta' ).on( inputEvent, '.quick-search', function() {
+            $( '#nav-menu-meta' ).on( 'input', '.quick-search', function() {
                 var $this = $( this );
 

trunk/src/js/_enqueues/wp/customize/nav-menus.js

@@ -157 +157 @@
         events: {
             'input #menu-items-search': 'debounceSearch',
-            'keyup #menu-items-search': 'debounceSearch',
             'focus .menu-item-tpl': 'focus',
             'click .menu-item-tpl': '_submit',

trunk/src/js/_enqueues/wp/customize/widgets.js

@@ -145 +145 @@
         events: {
             'input #widgets-search': 'search',
-            'keyup #widgets-search': 'search',
             'focus .widget-tpl' : 'focus',
             'click .widget-tpl' : '_submit',