Changeset 44554

Timestamp:

01/10/2019 11:19:37 PM (6 years ago)

Author:

pento

Message:

Emoji: Improve performance when encoding or staticizing emoji.

Both wp_encode_emoji() and wp_staticize_emoji() perform a PHP version check when deciding how to apply their behaviour, but this check only needs to happen once, rather than every time in their internal looks.

Moving the check outside of the loop reduces processing time by 50%.

Props johnbillion.
Fixes #45930.

File:

• trunk/src/wp-includes/formatting.php (modified) (2 diffs)

trunk/src/wp-includes/formatting.php

@@ -5478 +5478 @@
 function wp_encode_emoji( $content ) {
     $emoji = _wp_emoji_list( 'partials' );
+    $compat = version_compare( phpversion(), '5.4', '<' );
 
     foreach ( $emoji as $emojum ) {
-        if ( version_compare( phpversion(), '5.4', '<' ) ) {
+        if ( $compat ) {
             $emoji_char = html_entity_decode( $emojum, ENT_COMPAT, 'UTF-8' );
         } else {
@@ -5520 +5521 @@
     // Quickly narrow down the list of emoji that might be in the text and need replacing.
     $possible_emoji = array();
+    $compat         = version_compare( phpversion(), '5.4', '<' );
     foreach ( $emoji as $emojum ) {
         if ( false !== strpos( $text, $emojum ) ) {
-            if ( version_compare( phpversion(), '5.4', '<' ) ) {
+            if ( $compat ) {
                 $possible_emoji[ $emojum ] = html_entity_decode( $emojum, ENT_COMPAT, 'UTF-8' );
             } else {