Changeset 44569 for trunk/src/wp-includes/template.php

Timestamp:

01/12/2019 03:19:23 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Extract extract() from the codebase.

Of the last four instances of extract() occurring, three of them are removed by this commit, and the fourth is appropriately documented.

See #45934.

File:

• trunk/src/wp-includes/template.php (modified) (1 diff)

trunk/src/wp-includes/template.php

@@ -685 +685 @@
 
     if ( is_array( $wp_query->query_vars ) ) {
+        /*
+         * This use of extract() cannot be removed. There are many possible ways that
+         * templates could depend on variables that it creates existing, and no way to
+         * detect and deprecate it.
+         *
+         * Passing the EXTR_SKIP flag is the safest option, ensuring globals and
+         * function variables cannot be overwritten.
+         */
+        // phpcs:ignore WordPress.PHP.DontExtract.extract_extract
         extract( $wp_query->query_vars, EXTR_SKIP );
     }