Changeset 44569 for trunk/tests/phpunit/tests/shortcode.php

Timestamp:

01/12/2019 03:19:23 AM (6 years ago)

Author:

pento

Message:

Coding Standards: Extract extract() from the codebase.

Of the last four instances of extract() occurring, three of them are removed by this commit, and the fourth is appropriately documented.

See #45934.

File:

• trunk/tests/phpunit/tests/shortcode.php (modified) (1 diff)

trunk/tests/phpunit/tests/shortcode.php

@@ -44 +44 @@
     // [bartag foo="bar"]
     function _shortcode_bartag( $atts ) {
-        extract(
-            shortcode_atts(
-                array(
-                    'foo' => 'no foo',
-                    'baz' => 'default baz',
-                ),
-                $atts,
-                'bartag'
-            )
-        );
-
-        return "foo = {$foo}";
+        $processed_atts = shortcode_atts(
+            array(
+                'foo' => 'no foo',
+                'baz' => 'default baz',
+            ),
+            $atts,
+            'bartag'
+        );
+
+        return "foo = {$processed_atts['foo']}";
     }