Changeset 44617

Timestamp:

01/16/2019 06:00:23 AM (8 years ago)

Author:

pento

Message:

Plugin Editor: Disable the documentation look up button when no function is selected.

Props xkon.
Fixes #41143.

Location:

trunk/src

Files:

• js/_enqueues/wp/theme-plugin-editor.js (modified) (2 diffs)
• wp-admin/plugin-editor.php (modified) (1 diff)
• wp-admin/theme-editor.php (modified) (1 diff)

trunk/src/js/_enqueues/wp/theme-plugin-editor.js

@@ -54 +54 @@
                 component.textarea.on( 'change', component.onChange );
                 component.warning = $( '.file-editor-warning' );
+                component.docsLookUpButton = component.form.find( '#docs-lookup' );
+                component.docsLookUpList = component.form.find( '#docs-list' );
 
                 if ( component.warning.length > 0 ) {
@@ -77 +79 @@
                         }
                         return undefined;
+                } );
+
+                component.docsLookUpList.on( 'change', function() {
+                        var option = $( this ).val();
+                        if ( '' === option ) {
+                                component.docsLookUpButton.prop( 'disabled', true );
+                        } else {
+                                component.docsLookUpButton.prop( 'disabled', false );
+                        }
                 } );
         };

trunk/src/wp-admin/plugin-editor.php

@@ -266 +266 @@
                 </div>
                 <?php if ( ! empty( $docs_select ) ) : ?>
-                <div id="documentation" class="hide-if-no-js"><label for="docs-list"><?php _e( 'Documentation:' ); ?></label> <?php echo $docs_select; ?> <input type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ); ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ); ?>&amp;redirect=true'); }" /></div>
+                <div id="documentation" class="hide-if-no-js"><label for="docs-list"><?php _e( 'Documentation:' ); ?></label> <?php echo $docs_select; ?> <input disabled id="docs-lookup" type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?> " onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ); ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ); ?>&amp;redirect=true'); }" /></div>
                 <?php endif; ?>
 <?php if ( is_writeable( $real_file ) ) : ?>

trunk/src/wp-admin/theme-editor.php

@@ -286 +286 @@
                 <label for="docs-list"><?php _e( 'Documentation:' ); ?></label>
                 <?php echo $docs_select; ?>
-                <input type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?>" onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ); ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ); ?>&amp;redirect=true'); }" />
+                <input disabled id="docs-lookup" type="button" class="button" value="<?php esc_attr_e( 'Look Up' ); ?>" onclick="if ( '' != jQuery('#docs-list').val() ) { window.open( 'https://api.wordpress.org/core/handbook/1.0/?function=' + escape( jQuery( '#docs-list' ).val() ) + '&amp;locale=<?php echo urlencode( get_user_locale() ); ?>&amp;version=<?php echo urlencode( get_bloginfo( 'version' ) ); ?>&amp;redirect=true'); }" />
                 </div>
         <?php endif; ?>