Changeset 44627 for trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

Timestamp:

01/16/2019 05:05:37 PM (6 years ago)

Author:

flixos90

Message:

Plugins: Use centralized API to display information about updating PHP when a plugin requires a higher version.

This changeset uses the API functions introduced in [44476] to link to the resource about updating PHP when highlighting a plugin's required PHP version is not met. It furthermore expands them, introducing a new wp_update_php_annotation() function that prints the markup to indicate that the default URL has been altered by the web host, allowing it to be reused universally.

Furthermore, this changeset adds missing update_php capability checks before displaying the information about updating PHP.

Props afragen.
Fixes #45986. See #43986, #45686.

File:

• trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -636 +636 @@
                 if ( ! $compatible_php && ! $compatible_wp ) {
                     _e( 'This plugin doesn’t work with your versions of WordPress and PHP. ' );
-                    if ( current_user_can( 'update_core' ) ) {
+                    if ( current_user_can( 'update_core' ) && current_user_can( 'update_php' ) ) {
                         printf(
-                            /* translators: 1: "Update WordPress" screen URL, 2: "Updating PHP" page URL */
+                            /* translators: 1: "Update WordPress" screen URL, 2: "Update PHP" page URL */
                             __( '<a href="%1$s">Please update WordPress</a>, and then <a href="%2$s">learn more about updating PHP</a>.' ),
                             self_admin_url( 'update-core.php' ),
-                            esc_url( __( 'https://wordpress.org/support/update-php/' ) )
+                            esc_url( wp_get_update_php_url() )
                         );
-                    } else {
+                        wp_update_php_annotation();
+                    } elseif ( current_user_can( 'update_core' ) ) {
                         printf(
-                            /* translators: %s: "Updating PHP" page URL */
+                            /* translators: %s: "Update WordPress" screen URL */
+                            __( '<a href="%s">Please update WordPress</a>.' ),
+                            self_admin_url( 'update-core.php' )
+                        );
+                    } elseif ( current_user_can( 'update_php' ) ) {
+                        printf(
+                            /* translators: %s: "Update PHP" page URL */
                             __( '<a href="%s">Learn more about updating PHP</a>.' ),
-                            esc_url( __( 'https://wordpress.org/support/update-php/' ) )
+                            esc_url( wp_get_update_php_url() )
                         );
+                        wp_update_php_annotation();
                     }
                 } elseif ( ! $compatible_wp ) {
@@ -661 +669 @@
                 } elseif ( ! $compatible_php ) {
                     _e( 'This plugin doesn&#8217;t work with your version of PHP. ' );
-                    printf(
-                        /* translators: %s: "Updating PHP" page URL */
-                        __( '<a href="%s">Learn more about updating PHP</a>.' ),
-                        esc_url( __( 'https://wordpress.org/support/update-php/' ) )
-                    );
+                    if ( current_user_can( 'update_php' ) ) {
+                        printf(
+                            /* translators: %s: "Update PHP" page URL */
+                            __( '<a href="%s">Learn more about updating PHP</a>.' ),
+                            esc_url( wp_get_update_php_url() )
+                        );
+                        wp_update_php_annotation();
+                    }
                 }
                 echo '</p></div>';