Changeset 44634 for trunk/src/wp-admin/includes/media.php

Timestamp:

01/17/2019 06:26:05 AM (6 years ago)

Author:

pento

Message:

Media: media_handle_sideload() expectes wp_insert_attachment() to return a WP_Error.

For wp_insert_attachment() to do that, we need to be setting the $wp_error parameter to true.

Props subrataemfluence, jirihon.
Fixes #44303.

File:

• trunk/src/wp-admin/includes/media.php (modified) (1 diff)

trunk/src/wp-admin/includes/media.php

@@ -468 +468 @@
 
     // Save the attachment metadata
-    $id = wp_insert_attachment( $attachment, $file, $post_id );
+    $id = wp_insert_attachment( $attachment, $file, $post_id, true );
     if ( ! is_wp_error( $id ) ) {
         wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $file ) );