Changeset 44639

Timestamp:

01/17/2019 11:54:23 AM (6 years ago)

Author:

afercia

Message:

Accessibility: Improve the way Internet Explorer 11 and JAWS announce fieldset legends.

When Internet Explorer encounters a non interactive element with a tabindex
attribute, it adds the element to the accessibility tree with a role=group and
an accessible name computed from the element. This prevents JAWS from announcing
any fieldset legend within the element.

• removes tabindex="0" from the content and the toolbar containers: these tabindex attributes are no longer needed
• removes aria-label="Main content" from the content container: not needed
• keeps the media modal focus fallback introduced in [38142] by making the #wpbody-content element focusable only when needed

Props stevefaulkner, aardrian.
Fixes #43154.

Location:

trunk/src

Files:

• js/media/views/modal.js (modified) (1 diff)
• wp-admin/admin-header.php (modified) (1 diff)
• wp-includes/class-wp-admin-bar.php (modified) (1 diff)

trunk/src/js/media/views/modal.js

@@ -138 +138 @@
             this.clickedOpenerEl.focus();
         } else {
-            $( '#wpbody-content' ).focus();
+            $( '#wpbody-content' )
+                .attr( 'tabindex', '-1' )
+                .focus();
         }
 

trunk/src/wp-admin/admin-header.php

@@ -249 +249 @@
 ?>
 
-<div id="wpbody-content" aria-label="<?php esc_attr_e( 'Main content' ); ?>" tabindex="0">
+<div id="wpbody-content">
 <?php
 

trunk/src/wp-includes/class-wp-admin-bar.php

@@ -439 +439 @@
                 <a class="screen-reader-shortcut" href="#wp-toolbar" tabindex="1"><?php _e( 'Skip to toolbar' ); ?></a>
             <?php } ?>
-            <div class="quicklinks" id="wp-toolbar" role="navigation" aria-label="<?php esc_attr_e( 'Toolbar' ); ?>" tabindex="0">
+            <div class="quicklinks" id="wp-toolbar" role="navigation" aria-label="<?php esc_attr_e( 'Toolbar' ); ?>">
                 <?php
                 foreach ( $root->children as $group ) {