Changeset 44650 for trunk/src/wp-content/themes/twentynineteen/style-editor.scss

Timestamp:

01/18/2019 06:37:26 PM (8 years ago)

Author:

laurelfulford

Message:

Twenty Nineteen: Use a less aggressive approach for non-latin font fallbacks.

The theme's original approach to its non-latin font fallbacks required !important, which overrode fonts that shouldn't have been changed, like the icon fonts used for editor buttons.

Props kjellr, mako09, allancole.
Fixes #45731.

File:

• trunk/src/wp-content/themes/twentynineteen/style-editor.scss (modified) (17 diffs)

trunk/src/wp-content/themes/twentynineteen/style-editor.scss

@@ -79 +79 @@
 body {
         font-size: $font__size_base;
-        font-family: $font__body;
+        @include font-family( $font__body );
         line-height: $font__line-height-body;
         color: $color__text-main;
@@ -94 +94 @@
 h5,
 h6 {
-        font-family: $font__heading;
+        @include font-family( $font__heading );
         font-weight: 700;
 }
@@ -190 +190 @@
 figcaption,
 .gallery-caption {
-        font-family: $font__heading;
+        @include font-family( $font__heading );
         font-size: $font__size-xs;
         line-height: 1.6;
@@ -211 +211 @@
 
         .editor-post-title__input {
-                font-family: $font__heading;
+                @include font-family( $font__heading );
                 font-size: $font__size-xxl;
                 font-weight: 700;
@@ -220 +220 @@
 
 .editor-default-block-appender .editor-default-block-appender__content {
-        font-family: $font__body;
+        @include font-family( $font__body );
         font-size: $font__size_base;
 }
@@ -236 +236 @@
 
         &.has-drop-cap:not(:focus)::first-letter {
-                font-family: $font__heading;
+                @include font-family( $font__heading );
                 font-size: $font__size-xxxl;
                 line-height: 1;
@@ -247 +247 @@
 
 .wp-block-table {
-        font-family: $font__heading;
+        @include font-family( $font__heading );
 }
 
@@ -256 +256 @@
         h2,
         .wp-block-cover-text {
-                font-family: $font__heading;
+                @include font-family( $font__heading );
                 font-size: $font__size-lg;
                 font-weight: bold;
@@ -357 +357 @@
         .wp-block-button__link {
                 line-height: 1.8;
-                font-family: $font__heading;
+                @include font-family( $font__heading );
                 font-size: $font__size-sm;
                 font-weight: bold;
@@ -412 +412 @@
         footer,
         .wp-block-quote__citation {
-                font-family: $font__heading;
+                @include font-family( $font__heading );
                 font-size: $font__size-xs;
                 line-height: 1.6;
@@ -483 +483 @@
 
         .wp-block-pullquote__citation {
-                font-family: $font__heading;
+                @include font-family( $font__heading );
                 font-size: $font__size-xs;
                 line-height: 1.6;
@@ -532 +532 @@
 
 .wp-block-file {
-        font-family: $font__heading;
+        @include font-family( $font__heading );
 
         .wp-block-file__textlink {
@@ -626 +626 @@
         li {
                 color: $color__text-light;
-                font-family: $font__heading;
+                @include font-family( $font__heading );
                 font-size: calc(#{$font__size_base} * #{$font__size-ratio});
                 font-weight: bold;
@@ -687 +687 @@
 
         .wp-block-latest-comments__comment-meta {
-                font-family: $font__heading;
+                @include font-family( $font__heading );
                 font-weight: bold;
 
@@ -713 +713 @@
                 color: $color__text-light;
                 font-size: $font__size-xs;
-                font-family: $font__heading;
+                @include font-family( $font__heading );
                 line-height: $font__line-height-pre;
                 margin: 0;
@@ -731 +731 @@
 
                 cite {
-                        font-family: $font__heading;
+                        @include font-family( $font__heading );
                         font-size: $font__size-xs;
                         font-style: normal;
@@ -739 +739 @@
         }
 }
-
-/* Make sure our non-latin font overrides don't overwrite the iconfont used in the classic editor toolbar */
-.wp-block[data-type="core/freeform"] .mce-btn i {
-        font-family: dashicons !important;
-}