Changeset 44661

Timestamp:

01/21/2019 04:12:10 AM (8 years ago)

Author:

pento

Message:

Widgets: Fix Gallery Widget preview after an image is deleted.

The Gallery Widget incorrectly tried to include the deleted image in the preview.

Props westonruter, janak007, afercia, mrasharirfan.
Fixes #43139.

File:

• trunk/src/wp-includes/widgets/class-wp-widget-media-gallery.php (modified) (2 diffs)

trunk/src/wp-includes/widgets/class-wp-widget-media-gallery.php

@@ -177 +177 @@
                 <script type="text/html" id="tmpl-wp-media-widget-gallery-preview">
                         <# var describedById = 'describedBy-' + String( Math.random() ); #>
-                        <# if ( data.ids.length ) { #>
+                        <#
+                        var ids = _.filter( data.ids, function( id ) {
+                                return ( id in data.attachments );
+                        } );
+                        #>
+                        <# if ( ids.length ) { #>
                                 <div class="gallery media-widget-gallery-preview">
-                                        <# _.each( data.ids, function( id, index ) { #>
-                                                <#
-                                                var attachment = data.attachments[ id ];
-                                                if ( ! attachment ) {
-                                                        return;
-                                                }
-                                                #>
+                                        <# _.each( ids, function( id, index ) { #>
+                                                <# var attachment = data.attachments[ id ]; #>
                                                 <# if ( index < 6 ) { #>
                                                         <dl class="gallery-item">
@@ -194 +194 @@
                                                                         <img src="{{ attachment.url }}" alt="" />
                                                                 <# } #>
-                                                                <# if ( index === 5 && data.ids.length > 6 ) { #>
+                                                                <# if ( index === 5 && ids.length > 6 ) { #>
                                                                         <div class="gallery-icon-placeholder">
-                                                                                <p class="gallery-icon-placeholder-text">+{{ data.ids.length - 5 }}</p>
+                                                                                <p class="gallery-icon-placeholder-text">+{{ ids.length - 5 }}</p>
                                                                         </div>
                                                                 <# } #>