Changeset 44662 for trunk/src/wp-includes/option.php

Timestamp:

01/21/2019 04:26:33 AM (8 years ago)

Author:

peterwilsoncc

Message:

Options: Avoid unnecessary DB calls when updating network options.

Adds a maybe_serialize() comparison for the old and new values in update_network_option() to avoid unnecessary database writes when options contain identical objects.

Props bor0.
Fixes #44956.

File:

• trunk/src/wp-includes/option.php (modified) (1 diff)

trunk/src/wp-includes/option.php

@@ -1584 +1584 @@
         $value = apply_filters( "pre_update_site_option_{$option}", $value, $old_value, $option, $network_id );
 
-        if ( $value === $old_value ) {
+        /*
+         * If the new and old values are the same, no need to update.
+         *
+         * Unserialized values will be adequate in most cases. If the unserialized
+         * data differs, the (maybe) serialized data is checked to avoid
+         * unnecessary database calls for otherwise identical object instances.
+         *
+         * See https://core.trac.wordpress.org/ticket/44956
+         */
+        if ( $value === $old_value || maybe_serialize( $value ) === maybe_serialize( $old_value ) ) {
                 return false;
         }