Changeset 44670

Timestamp:

01/21/2019 06:04:55 PM (8 years ago)

Author:

SergeyBiryukov

Message:

Post Formats: Prevent Bulk Edit from unintentionally changing post format to Standard even if set to "No change".

Correct the logic in [41187].

Props birgire, mukesh27, lanche86.
Fixes #44914. See #41396.

Location:

trunk

Files:

• src/wp-admin/includes/post.php (modified) (1 diff)
• tests/phpunit/tests/admin/includesPost.php (modified) (1 diff)

trunk/src/wp-admin/includes/post.php

@@ -611 +611 @@
                 if ( isset( $shared_post_data['post_format'] ) ) {
                         set_post_format( $post_ID, $shared_post_data['post_format'] );
-                        unset( $post_data['tax_input']['post_format'] );
-                }
+                }
+
+                // Prevent wp_insert_post() from overwriting post format with the old data.
+                unset( $post_data['tax_input']['post_format'] );
 
                 $updated[] = wp_update_post( $post_data );

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -256 +256 @@
 
         /**
+         * The bulk_edit_posts() function should preserve the post format
+         * when it's unchanged.
+         *
+         * @ticket 44914
+         */
+        public function test_bulk_edit_posts_should_preserve_post_format_when_unchanged() {
+                wp_set_current_user( self::$admin_id );
+
+                $post_ids = self::factory()->post->create_many( 3 );
+
+                set_post_format( $post_ids[0], 'image' );
+                set_post_format( $post_ids[1], 'aside' );
+
+                $request = array(
+                        'post_format'    => -1, // Don't change the post format.
+                        '_status'        => -1,
+                        'post'           => $post_ids,
+                );
+
+                bulk_edit_posts( $request );
+
+                $terms1 = get_the_terms( $post_ids[0], 'post_format' );
+                $terms2 = get_the_terms( $post_ids[1], 'post_format' );
+                $terms3 = get_the_terms( $post_ids[2], 'post_format' );
+
+                $this->assertSame( 'post-format-image', $terms1[0]->slug );
+                $this->assertSame( 'post-format-aside', $terms2[0]->slug );
+                $this->assertFalse( $terms3 );
+
+                $this->assertSame( 'image', get_post_format( $post_ids[0] ) );
+                $this->assertSame( 'aside', get_post_format( $post_ids[1] ) );
+                $this->assertFalse( get_post_format( $post_ids[2] ) );
+        }
+
+        /**
          * @ticket 41396
          */