Changeset 44671 for trunk/src/wp-includes/class-wp-shutdown-handler.php

Timestamp:

01/21/2019 07:09:23 PM (6 years ago)

Author:

flixos90

Message:

Bootstrap/Load: Ensure that the fatal error shutdown handler does not prevent other shutdown handlers from being called.

This changeset adds support for a new wp_die() argument exit, which defaults to true and determines whether wp_die() should actually terminate the request. The new fatal error handler then calls wp_die() with that argument set to false, as calling die() or exit from a PHP shutdown function prevents other shutdown functions from being called.

Props schlessera, johnbillion.
Fixes #46038. See #44458.

File:

• trunk/src/wp-includes/class-wp-shutdown-handler.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-shutdown-handler.php

@@ -137 +137 @@
             if ( is_readable( $php_error_pluggable ) ) {
                 require_once $php_error_pluggable;
-                die();
+                return;
             }
         }
@@ -167 +167 @@
         $message = __( 'The site is experiencing technical difficulties.' );
 
-        $args = array( 'response' => 500 );
+        $args = array(
+            'response' => 500,
+            'exit'     => false,
+        );
         if ( function_exists( 'admin_url' ) ) {
             $args['link_url']  = admin_url();