Changeset 44684

Timestamp:

01/21/2019 11:02:39 PM (8 years ago)

Author:

pento

Message:

Customiser: Prevent JS errors when previewing pages with an <area> tag.

The customiser assumes that <area> tags will have a href attribute, which isn't necessarily true. Now it checks instead of assuming.

Props janthiel, adamsilverstein.
Fixes #45053.

File:

• trunk/src/js/_enqueues/wp/customize/preview.js (modified) (4 diffs)

trunk/src/js/_enqueues/wp/customize/preview.js

@@ -238 +238 @@
          */
         api.addLinkPreviewing = function addLinkPreviewing() {
-                var linkSelectors = 'a[href], area';
+                var linkSelectors = 'a[href], area[href]';
 
                 // Inject links into initial document.
@@ -337 +337 @@
         api.prepareLinkPreview = function prepareLinkPreview( element ) {
                 var queryParams, $element = $( element );
+
+        // Skip elements with no href attribute. Check first to avoid more expensive checks down the road
+        if ( ! element.hasAttribute( 'href' ) ) {
+            return;
+        }
 
                 // Skip links in admin bar.
@@ -777 +782 @@
 
                         // Update UUIDs in links and forms.
-                        $( document.body ).find( 'a[href], area' ).each( function() {
+                        $( document.body ).find( 'a[href], area[href]' ).each( function() {
                                 api.prepareLinkPreview( this );
                         } );
@@ -811 +816 @@
                         api.settings.changeset.autosaved = true; // Start deferring to any autosave once changeset is updated.
 
-                        $( document.body ).find( 'a[href], area' ).each( function() {
+                        $( document.body ).find( 'a[href], area[href]' ).each( function() {
                                 api.prepareLinkPreview( this );
                         } );