Changeset 44691 for trunk/src/wp-includes/formatting.php

Timestamp:

01/22/2019 09:54:26 PM (6 years ago)

Author:

peterwilsoncc

Message:

Formatting: Prevent wp_targeted_link_rel() adding an empty attribute.

Bypass adding a rel attribute when the wp_targeted_link_rel filter returns an empty string or other falsy result.

Props mcmwebsol, spartank, meatman89fs.
Fixes #45352.

File:

• trunk/src/wp-includes/formatting.php (modified) (1 diff)

trunk/src/wp-includes/formatting.php

@@ -3066 +3066 @@
     $rel = apply_filters( 'wp_targeted_link_rel', 'noopener noreferrer', $link_html );
 
+    // Avoid additional regex if the filter removes rel values.
+    if ( ! $rel ) {
+        return "<a $link_html>";
+    }
+
     // Value with delimiters, spaces around are optional.
     $attr_regex = '|rel\s*=\s*?(\\\\{0,1}["\'])(.*?)\\1|i';