Changeset 44696

Timestamp:

01/24/2019 11:20:25 AM (8 years ago)

Author:

azaozz

Message:

TinyMCE Classic Block: fix the Advanced Link modal (accessible when clicking on the cogwheel in the inline link modal in a Classic Block).

Fixes #46071.

Location:

trunk/src/js/_enqueues

Files:

• lib/link.js (modified) (11 diffs)
• vendor/tinymce/plugins/wplink/plugin.js (modified) (4 diffs)

trunk/src/js/_enqueues/lib/link.js

@@ -6 +6 @@
 
 ( function( $, wpLinkL10n, wp ) {
-        var editor, searchTimer, River, Query, correctedURL, linkNode,
+        var editor, searchTimer, River, Query, correctedURL,
                 emailRegexp = /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,63}$/i,
                 urlRegexp = /^(https?|ftp):\/\/[A-Z0-9.-]+\.[A-Z]{2,63}[^ "]*$/i,
@@ -14 +14 @@
 
         function getLink() {
-                return linkNode || editor.dom.getParent( editor.selection.getNode(), 'a[href]' );
+                if ( editor ) {
+                        return editor.$( 'a[data-wplink-edit="true"]' );
+                }
+
+                return null;
         }
 
@@ -98 +102 @@
                 },
 
-                open: function( editorId, url, text, node ) {
+                open: function( editorId, url, text ) {
                         var ed,
                                 $body = $( document.body );
@@ -104 +108 @@
                         $body.addClass( 'modal-open' );
                         wpLink.modalOpen = true;
-                        linkNode = node;
 
                         wpLink.range = null;
@@ -206 +209 @@
                         }
 
-                        if ( linkNode ) {
-                                nodes = linkNode.childNodes;
-
-                                if ( nodes.length === 0 ) {
+                        if ( linkNode.length ) {
+                                nodes = linkNode[0].childNodes;
+
+                                if ( ! nodes || ! nodes.length ) {
                                         return false;
                                 }
@@ -230 +233 @@
                                 onlyText = this.hasSelectedText( linkNode );
 
-                        if ( linkNode ) {
-                                linkText = linkNode.textContent || linkNode.innerText;
-                                href = editor.dom.getAttrib( linkNode, 'href' );
+                        if ( linkNode.length ) {
+                                linkText = linkNode.text();
+                                href = linkNode.attr( 'href' );
 
                                 if ( ! $.trim( linkText ) ) {
@@ -244 +247 @@
                                 if ( href !== '_wp_link_placeholder' ) {
                                         inputs.url.val( href );
-                                        inputs.openInNewTab.prop( 'checked', '_blank' === editor.dom.getAttrib( linkNode, 'target' ) );
+                                        inputs.openInNewTab.prop( 'checked', '_blank' === linkNode.attr( 'target' ) );
                                         inputs.submit.val( wpLinkL10n.update );
                                 } else {
@@ -415 +418 @@
                         }
 
-                        $link = editor.$( getLink() );
+                        $link = getLink();
 
                         editor.undoManager.transact( function() {
@@ -438 +441 @@
 
                                         attrs['data-wplink-edit'] = null;
-                                        attrs['data-mce-href'] = null; // attrs.href
+                                        attrs['data-mce-href'] = attrs.href;
                                         $link.attr( attrs );
                                 }
@@ -447 +450 @@
 
                         if ( $link.length ) {
-                                $mceCaret = $link.parent( '#_mce_caret' );
-
-                                if ( $mceCaret.length ) {
-                                        $mceCaret.before( $link.removeAttr( 'data-mce-bogus' ) );
-                                }
-
                                 editor.selection.select( $link[0] );
-                                editor.selection.collapse();
 
                                 if ( editor.plugins.wplink ) {
@@ -469 +465 @@
                 updateFields: function( e, li ) {
                         inputs.url.val( li.children( '.item-permalink' ).val() );
+
+                        if ( inputs.wrap.hasClass( 'has-text-field' ) && ! inputs.text.val() ) {
+                                inputs.text.val( li.children( '.item-title' ).text() );
+                        }
                 },
 

trunk/src/js/_enqueues/vendor/tinymce/plugins/wplink/plugin.js

@@ -227 +227 @@
                         editToolbar.tempHide = false;
 
-                        if ( linkNode ) {
-                                editor.dom.setAttribs( linkNode, { 'data-wplink-edit': true } );
-                        } else {
+                        if ( ! linkNode ) {
                                 removePlaceholders();
                                 editor.execCommand( 'mceInsertLink', false, { href: '_wp_link_placeholder' } );
@@ -236 +234 @@
                                 editor.nodeChanged();
                         }
+
+                        editor.dom.setAttribs( linkNode, { 'data-wplink-edit': true } );
                 } );
 
@@ -285 +285 @@
 
                 editor.addCommand( 'wp_link_cancel', function() {
+                        inputInstance.reset();
+
                         if ( ! editToolbar.tempHide ) {
-                                inputInstance.reset();
                                 removePlaceholders();
                         }
@@ -584 +585 @@
                                                 text = inputInstance.getLinkText() || null;
 
-                                        /*
-                                         * Accessibility note: moving focus back to the editor confuses
-                                         * screen readers. They will announce again the Editor ARIA role
-                                         * `application` and the iframe `title` attribute.
-                                         *
-                                         * Unfortunately IE looses the selection when the editor iframe
-                                         * looses focus, so without returning focus to the editor, the code
-                                         * in the modal will not be able to get the selection, place the caret
-                                         * at the same location, etc.
-                                         */
-                                        if ( tinymce.Env.ie ) {
-                                                editor.focus(); // Needed for IE
-                                        }
+                                        window.wpLink.open( editor.id, url, text );
 
                                         editToolbar.tempHide = true;
-                                        window.wpLink.open( editor.id, url, text, linkNode );
-
-                                        inputInstance.reset();
+                                        editToolbar.hide();
                                 }
                         }