Changeset 44717 for trunk/src/wp-admin/includes/plugin.php

Timestamp:

01/30/2019 11:00:30 AM (6 years ago)

Author:

flixos90

Message:

Bootstrap/Load: Revert fatal error recovery mechanism from 5.1 to polish for 5.2.

Due to the high number of follow-up tickets and associated security concerns, it was decided to reschedule the fatal error recovery feature for WordPress 5.2, in order to address these issues properly. The feature will continue to be developed, with iterations being merged into trunk early in the 5.2 release cycle.

Fixes #46141. See #44458, #45932, #45940, #46038, #46047, #46068.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (6 diffs)

trunk/src/wp-admin/includes/plugin.php

@@ -469 +469 @@
 function _get_dropins() {
     $dropins = array(
-        'advanced-cache.php'      => array( __( 'Advanced caching plugin.' ), 'WP_CACHE' ), // WP_CACHE
-        'db.php'                  => array( __( 'Custom database class.' ), true ), // auto on load
-        'db-error.php'            => array( __( 'Custom database error message.' ), true ), // auto on error
-        'install.php'             => array( __( 'Custom installation script.' ), true ), // auto on installation
-        'maintenance.php'         => array( __( 'Custom maintenance message.' ), true ), // auto on maintenance
-        'object-cache.php'        => array( __( 'External object cache.' ), true ), // auto on load
-        'php-error.php'           => array( __( 'Custom PHP error message.' ), true ), // auto on error
-        'fatal-error-handler.php' => array( __( 'Custom PHP fatal error handler.' ), true ), // auto on error
+        'advanced-cache.php' => array( __( 'Advanced caching plugin.' ), 'WP_CACHE' ), // WP_CACHE
+        'db.php'             => array( __( 'Custom database class.' ), true ), // auto on load
+        'db-error.php'       => array( __( 'Custom database error message.' ), true ), // auto on error
+        'install.php'        => array( __( 'Custom installation script.' ), true ), // auto on installation
+        'maintenance.php'    => array( __( 'Custom maintenance message.' ), true ), // auto on maintenance
+        'object-cache.php'   => array( __( 'External object cache.' ), true ), // auto on load
     );
 
@@ -527 +525 @@
 function is_plugin_inactive( $plugin ) {
     return ! is_plugin_active( $plugin );
-}
-
-/**
- * Determines whether a plugin is technically active but was paused while
- * loading.
- *
- * For more information on this and similar theme functions, check out
- * the {@link https://developer.wordpress.org/themes/basics/conditional-tags/
- * Conditional Tags} article in the Theme Developer Handbook.
- *
- * @since 5.1.0
- *
- * @param string $plugin Path to the plugin file relative to the plugins directory.
- * @return bool True, if in the list of paused plugins. False, not in the list.
- */
-function is_plugin_paused( $plugin ) {
-    if ( ! isset( $GLOBALS['_paused_plugins'] ) ) {
-        return false;
-    }
-
-    if ( ! is_plugin_active( $plugin ) && ! is_plugin_active_for_network( $plugin ) ) {
-        return false;
-    }
-
-    list( $plugin ) = explode( '/', $plugin );
-
-    return array_key_exists( $plugin, $GLOBALS['_paused_plugins'] );
-}
-
-/**
- * Gets the error that was recorded for a paused plugin.
- *
- * @since 5.1.0
- *
- * @param string $plugin Path to the plugin file relative to the plugins
- *                       directory.
- * @return array|false Array of error information as it was returned by
- *                     `error_get_last()`, or false if none was recorded.
- */
-function wp_get_plugin_error( $plugin ) {
-    if ( ! isset( $GLOBALS['_paused_plugins'] ) ) {
-        return false;
-    }
-
-    list( $plugin ) = explode( '/', $plugin );
-
-    if ( ! array_key_exists( $plugin, $GLOBALS['_paused_plugins'] ) ) {
-        return false;
-    }
-
-    return $GLOBALS['_paused_plugins'][ $plugin ];
-}
-
-/**
- * Gets the number of sites on which a specific plugin is paused.
- *
- * @since 5.1.0
- *
- * @param string $plugin Path to the plugin file relative to the plugins directory.
- * @return int Site count.
- */
-function count_paused_plugin_sites_for_network( $plugin ) {
-    if ( ! is_multisite() ) {
-        return is_plugin_paused( $plugin ) ? 1 : 0;
-    }
-
-    list( $plugin ) = explode( '/', $plugin );
-
-    $query_args = array(
-        'count'      => true,
-        'number'     => 0,
-        'network_id' => get_current_network_id(),
-        'meta_query' => array(
-            wp_paused_plugins()->get_site_meta_query_clause( $plugin ),
-        ),
-    );
-
-    return get_sites( $query_args );
 }
 
@@ -802 +722 @@
         if ( ! is_plugin_active( $plugin ) ) {
             continue;
-        }
-
-        // Clean up the database before deactivating the plugin.
-        if ( is_plugin_paused( $plugin ) ) {
-            resume_plugin( $plugin );
         }
 
@@ -1003 +918 @@
         }
 
-        // Clean up the database before removing the plugin.
-        if ( is_plugin_paused( $plugin_file ) ) {
-            resume_plugin( $plugin_file );
-        }
-
         /**
          * Fires immediately before a plugin deletion attempt.
@@ -1080 +990 @@
 
         return new WP_Error( 'could_not_remove_plugin', sprintf( $message, implode( ', ', $errors ) ) );
-    }
-
-    return true;
-}
-
-/**
- * Tries to resume a single plugin.
- *
- * If a redirect was provided, we first ensure the plugin does not throw fatal
- * errors anymore.
- *
- * The way it works is by setting the redirection to the error before trying to
- * include the plugin file. If the plugin fails, then the redirection will not
- * be overwritten with the success message and the plugin will not be resumed.
- *
- * @since 5.1.0
- *
- * @param string $plugin       Single plugin to resume.
- * @param string $redirect     Optional. URL to redirect to. Default empty string.
- * @param bool   $network_wide Optional. Whether to resume the plugin for the entire
- *                             network. Default false.
- * @return bool|WP_Error True on success, false if `$plugin` was not paused,
- *                       `WP_Error` on failure.
- */
-function resume_plugin( $plugin, $redirect = '', $network_wide = false ) {
-    /*
-     * We'll override this later if the plugin could be included without
-     * creating a fatal error.
-     */
-    if ( ! empty( $redirect ) ) {
-        wp_redirect(
-            add_query_arg(
-                '_error_nonce',
-                wp_create_nonce( 'plugin-resume-error_' . $plugin ),
-                $redirect
-            )
-        );
-
-        // Load the plugin to test whether it throws a fatal error.
-        ob_start();
-        plugin_sandbox_scrape( $plugin );
-        ob_clean();
-    }
-
-    $result = wp_forget_extension_error( 'plugins', $plugin, $network_wide );
-
-    if ( ! $result ) {
-        return new WP_Error(
-            'could_not_resume_plugin',
-            __( 'Could not resume the plugin.' )
-        );
     }
 
@@ -2243 +2102 @@
     WP_Privacy_Policy_Content::add( $plugin_name, $policy_text );
 }
-
-/**
- * Renders an admin notice in case some plugins have been paused due to errors.
- *
- * @since 5.1.0
- */
-function paused_plugins_notice() {
-    if ( 'plugins.php' === $GLOBALS['pagenow'] ) {
-        return;
-    }
-
-    if ( ! current_user_can( 'deactivate_plugins' ) ) {
-        return;
-    }
-
-    if ( ! isset( $GLOBALS['_paused_plugins'] ) || empty( $GLOBALS['_paused_plugins'] ) ) {
-        return;
-    }
-
-    printf(
-        '<div class="notice notice-error"><p><strong>%s</strong><br>%s</p><p>%s</p></div>',
-        __( 'One or more plugins failed to load properly.' ),
-        __( 'You can find more details and make changes on the Plugins screen.' ),
-        sprintf(
-            '<a href="%s">%s</a>',
-            admin_url( 'plugins.php?plugin_status=paused' ),
-            'Go to the Plugins screen'
-        )
-    );
-}