Changeset 44717 for trunk/src/wp-admin/plugins.php

Timestamp:

01/30/2019 11:00:30 AM (4 years ago)

Author:

flixos90

Message:

Bootstrap/Load: Revert fatal error recovery mechanism from 5.1 to polish for 5.2.

Due to the high number of follow-up tickets and associated security concerns, it was decided to reschedule the fatal error recovery feature for WordPress 5.2, in order to address these issues properly. The feature will continue to be developed, with iterations being merged into trunk early in the 5.2 release cycle.

Fixes #46141. See #44458, #45932, #45940, #46038, #46047, #46068.

File:

• trunk/src/wp-admin/plugins.php (modified) (3 diffs)

trunk/src/wp-admin/plugins.php

@@ -390 +390 @@
             break;
 
-        case 'resume':
-            if ( ! current_user_can( 'resume_plugin', $plugin ) ) {
-                wp_die( __( 'Sorry, you are not allowed to resume this plugin.' ) );
-            }
-
-            if ( is_multisite() && ! is_network_admin() && is_network_only_plugin( $plugin ) ) {
-                wp_redirect( self_admin_url( "plugins.php?plugin_status=$status&paged=$page&s=$s" ) );
-                exit;
-            }
-
-            check_admin_referer( 'resume-plugin_' . $plugin );
-
-            $result = resume_plugin( $plugin, self_admin_url( 'plugins.php?error=resuming' ), is_network_admin() );
-
-            if ( is_wp_error( $result ) ) {
-                wp_die( $result );
-            }
-
-            wp_redirect( self_admin_url( "plugins.php?resume=true&plugin_status=$status&paged=$page&s=$s" ) );
-            exit;
-
         default:
             if ( isset( $_POST['checked'] ) ) {
@@ -510 +489 @@
         );
         $errmsg .= ' ' . __( 'If you notice “headers already sent” messages, problems with syndication feeds or other issues, try deactivating or removing this plugin.' );
-    } elseif ( 'resuming' === $_GET['error'] ) {
-        $errmsg = __( 'Plugin could not be resumed because it triggered a <strong>fatal error</strong>.' );
     } else {
         $errmsg = __( 'Plugin could not be activated because it triggered a <strong>fatal error</strong>.' );
@@ -565 +542 @@
 <?php elseif ( 'update-selected' == $action ) : ?>
     <div id="message" class="updated notice is-dismissible"><p><?php _e( 'All selected plugins are up to date.' ); ?></p></div>
-<?php elseif ( isset( $_GET['resume'] ) ) : ?>
-    <div id="message" class="updated notice is-dismissible"><p><?php _e( 'Plugin <strong>resumed</strong>.' ); ?></p></div>
 <?php endif; ?>