Changeset 44717 for trunk/src/wp-admin/themes.php

Timestamp:

01/30/2019 11:00:30 AM (6 years ago)

Author:

flixos90

Message:

Bootstrap/Load: Revert fatal error recovery mechanism from 5.1 to polish for 5.2.

Due to the high number of follow-up tickets and associated security concerns, it was decided to reschedule the fatal error recovery feature for WordPress 5.2, in order to address these issues properly. The feature will continue to be developed, with iterations being merged into trunk early in the 5.2 release cycle.

Fixes #46141. See #44458, #45932, #45940, #46038, #46047, #46068.

File:

• trunk/src/wp-admin/themes.php (modified) (5 diffs)

trunk/src/wp-admin/themes.php

@@ -33 +33 @@
         switch_theme( $theme->get_stylesheet() );
         wp_redirect( admin_url( 'themes.php?activated=true' ) );
-        exit;
-    } elseif ( 'resume' === $_GET['action'] ) {
-        check_admin_referer( 'resume-theme_' . $_GET['stylesheet'] );
-        $theme = wp_get_theme( $_GET['stylesheet'] );
-
-        if ( ! current_user_can( 'resume_themes' ) ) {
-            wp_die(
-                '<h1>' . __( 'You need a higher level of permission.' ) . '</h1>' .
-                '<p>' . __( 'Sorry, you are not allowed to resume this theme.' ) . '</p>',
-                403
-            );
-        }
-
-        $result = resume_theme( $theme->get_stylesheet() );
-
-        if ( is_wp_error( $result ) ) {
-            wp_die( $result );
-        }
-
-        wp_redirect( admin_url( 'themes.php?resumed=true' ) );
         exit;
     } elseif ( 'delete' == $_GET['action'] ) {
@@ -216 +196 @@
     <div id="message4" class="error"><p><?php _e( 'You cannot delete a theme while it has an active child theme.' ); ?></p></div>
     <?php
-} elseif ( isset( $_GET['resumed'] ) ) {
-    ?>
-    <div id="message5" class="updated notice is-dismissible"><p><?php _e( 'Theme resumed.' ); ?></p></div>
-    <?php
 }
 
@@ -373 +349 @@
 
     <?php
-    $can_resume  = current_user_can( 'resume_themes' );
     $can_delete  = current_user_can( 'delete_themes' );
     $can_install = current_user_can( 'install_themes' );
@@ -381 +356 @@
         <th><?php _ex( 'Name', 'theme name' ); ?></th>
         <th><?php _e( 'Description' ); ?></th>
-        <?php if ( $can_resume ) { ?>
-            <td></td>
-        <?php } ?>
         <?php if ( $can_delete ) { ?>
             <td></td>
@@ -396 +368 @@
             <td><?php echo $broken_theme->errors()->get_error_message(); ?></td>
             <?php
-            if ( $can_resume ) {
-                if ( 'theme_paused' === $broken_theme->errors()->get_error_code() ) {
-                    $stylesheet = $broken_theme->get_stylesheet();
-                    $resume_url = add_query_arg(
-                        array(
-                            'action'     => 'resume',
-                            'stylesheet' => urlencode( $stylesheet ),
-                        ),
-                        admin_url( 'themes.php' )
-                    );
-                    $resume_url = wp_nonce_url( $resume_url, 'resume-theme_' . $stylesheet );
-                    ?>
-                    <td><a href="<?php echo esc_url( $resume_url ); ?>" class="button resume-theme"><?php _e( 'Resume' ); ?></a></td>
-                    <?php
-                } else {
-                    ?>
-                    <td></td>
-                    <?php
-                }
-            }
-
             if ( $can_delete ) {
                 $stylesheet = $broken_theme->get_stylesheet();