Changeset 44757

Timestamp:

02/20/2019 10:08:23 PM (6 years ago)

Author:

afercia

Message:

Accessibility: Improve buttons placement in the Comments Quick edit/Reply form.

Proximity of related information is an inclusive design principle that benefits everyone and it's particularly important for users with reduced visual field, low vision, or other vision or cognitive impairments. User interface controls that are logically grouped should be placed close to each other.
Also, this change makes the buttons visual order and the DOM order match.

Fixes #45972.

Location:

trunk/src/wp-admin

Files:

• css/list-tables.css (modified) (1 diff)
• includes/template.php (modified) (1 diff)

trunk/src/wp-admin/css/list-tables.css

@@ -153 +153 @@
 }
 
+#replysubmit .reply-submit-buttons {
+    margin-bottom: 0;
+}
+
 #replysubmit .button {
     margin-right: 5px;
+}
+
+#replysubmit .spinner {
+    float: none;
+    margin: -4px 0 0;
 }
 

trunk/src/wp-admin/includes/template.php

@@ -480 +480 @@
 
     <div id="replysubmit" class="submit">
-        <p>
-            <a href="#comments-form" class="save button button-primary alignright">
+        <p class="reply-submit-buttons">
+            <a href="#comments-form" class="save button button-primary">
                 <span id="addbtn" style="display: none;"><?php _e( 'Add Comment' ); ?></span>
                 <span id="savebtn" style="display: none;"><?php _e( 'Update Comment' ); ?></span>
                 <span id="replybtn" style="display: none;"><?php _e( 'Submit Reply' ); ?></span>
             </a>
-            <a href="#comments-form" class="cancel button alignleft"><?php _e( 'Cancel' ); ?></a>
+            <a href="#comments-form" class="cancel button"><?php _e( 'Cancel' ); ?></a>
             <span class="waiting spinner"></span>
         </p>
-        <br class="clear" />
         <div class="notice notice-error notice-alt inline hidden">
             <p class="error"></p>