Changeset 44785 for trunk/src/wp-admin/custom-header.php

Timestamp:

03/01/2019 08:57:26 PM (7 years ago)

Author:

jorbin

Message:

Replace usages of basename() with wp_basename() in order to support multibyte filenames

This is focused on the pieces of code that touch media files and the tests that support them. basename isn't multibyte compatible out of the box. See ​http://php.net/basename and ​https://bugs.php.net/bug.php?id=62119.

See #43170.
Props Viper007Bond.

File:

• trunk/src/wp-admin/custom-header.php (modified) (6 diffs)

trunk/src/wp-admin/custom-header.php

@@ -821 +821 @@
                 } elseif ( $width > $max_width ) {
                         $oitar = $width / $max_width;
-                        $image = wp_crop_image( $attachment_id, 0, 0, $width, $height, $max_width, $height / $oitar, false, str_replace( basename( $file ), 'midsize-' . basename( $file ), $file ) );
+                        $image = wp_crop_image( $attachment_id, 0, 0, $width, $height, $max_width, $height / $oitar, false, str_replace( wp_basename( $file ), 'midsize-' . wp_basename( $file ), $file ) );
                         if ( ! $image || is_wp_error( $image ) ) {
                                 wp_die( __( 'Image could not be processed. Please go back and try again.' ), __( 'Image Processing Error' ) );
@@ -829 +829 @@
                         $image = apply_filters( 'wp_create_file_in_uploads', $image, $attachment_id ); // For replication
 
-                        $url    = str_replace( basename( $url ), basename( $image ), $url );
+                        $url    = str_replace( wp_basename( $url ), wp_basename( $image ), $url );
                         $width  = $width / $oitar;
                         $height = $height / $oitar;
@@ -896 +896 @@
                 $type     = $file['type'];
                 $file     = $file['file'];
-                $filename = basename( $file );
+                $filename = wp_basename( $file );
 
                 // Construct the object array
@@ -985 +985 @@
 
                 // Cleanup.
-                $medium = str_replace( basename( $original ), 'midsize-' . basename( $original ), $original );
+                $medium = str_replace( wp_basename( $original ), 'midsize-' . wp_basename( $original ), $original );
                 if ( file_exists( $medium ) ) {
                         wp_delete_file( $medium );
@@ -1209 +1209 @@
                 $parent     = get_post( $parent_attachment_id );
                 $parent_url = wp_get_attachment_url( $parent->ID );
-                $url        = str_replace( basename( $parent_url ), basename( $cropped ), $parent_url );
+                $url        = str_replace( wp_basename( $parent_url ), wp_basename( $cropped ), $parent_url );
 
                 $size       = @getimagesize( $cropped );
@@ -1216 +1216 @@
                 $object = array(
                         'ID'             => $parent_attachment_id,
-                        'post_title'     => basename( $cropped ),
+                        'post_title'     => wp_basename( $cropped ),
                         'post_mime_type' => $image_type,
                         'guid'           => $url,