Changeset 44796 for trunk/src/wp-includes/customize/class-wp-customize-site-icon-control.php

Timestamp:

03/05/2019 05:49:00 PM (7 years ago)

Author:

afercia

Message:

Accessibility: Replace media placeholder clickable divs with buttons.

<button> elements are natively interactive, supported by any assistive technology, and must be used instead of non-semantic, non-accessible <div> elements.

Also, this change aligns the Media Widgets and the Customizer site icon and site logo controls with the design pattern used in the new Block Editor for similar controls.

Props ramonopoly, welcher, afercia.
Fixes #43151.

File:

• trunk/src/wp-includes/customize/class-wp-customize-site-icon-control.php (modified) (3 diffs)

trunk/src/wp-includes/customize/class-wp-customize-site-icon-control.php

@@ -48 +48 @@
     public function content_template() {
         ?>
-        <label for="{{ data.settings['default'] }}-button">
-            <# if ( data.label ) { #>
-                <span class="customize-control-title">{{ data.label }}</span>
-            <# } #>
-            <# if ( data.description ) { #>
-                <span class="description customize-control-description">{{{ data.description }}}</span>
-            <# } #>
-        </label>
+        <# if ( data.label ) { #>
+            <span class="customize-control-title">{{ data.label }}</span>
+        <# } #>
+        <# if ( data.description ) { #>
+            <span class="description customize-control-description">{{{ data.description }}}</span>
+        <# } #>
 
         <# if ( data.attachment && data.attachment.id ) { #>
@@ -75 +73 @@
                     <# if ( data.canUpload ) { #>
                         <button type="button" class="button remove-button"><?php echo $this->button_labels['remove']; ?></button>
-                        <button type="button" class="button upload-button" id="{{ data.settings['default'] }}-button"><?php echo $this->button_labels['change']; ?></button>
+                        <button type="button" class="button upload-button"><?php echo $this->button_labels['change']; ?></button>
                     <# } #>
                 </div>
@@ -81 +79 @@
         <# } else { #>
             <div class="attachment-media-view">
-                <div class="placeholder">
-                    <?php echo $this->button_labels['placeholder']; ?>
-                </div>
+                <# if ( data.canUpload ) { #>
+                    <button type="button" class="upload-button button-add-media"><?php echo $this->button_labels['site_icon']; ?></button>
+                <# } #>
                 <div class="actions">
                     <# if ( data.defaultAttachment ) { #>
                         <button type="button" class="button default-button"><?php echo $this->button_labels['default']; ?></button>
-                    <# } #>
-                    <# if ( data.canUpload ) { #>
-                        <button type="button" class="button upload-button" id="{{ data.settings['default'] }}-button"><?php echo $this->button_labels['select']; ?></button>
                     <# } #>
                 </div>