Changeset 44813

Timestamp:

03/07/2019 12:34:56 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Users: Use login__in parameter for WP_User_Query in WP_MS_Users_List_Table::prepare_items(), instead of a manual query.

Props spacedmonkey.
Fixes #45223.

File:

• trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-ms-users-list-table.php

@@ -27 +27 @@
      * @global string $usersearch
      * @global string $role
-     * @global wpdb   $wpdb
      * @global string $mode
      */
     public function prepare_items() {
-        global $usersearch, $role, $wpdb, $mode;
+        global $usersearch, $role, $mode;
 
         $usersearch = isset( $_REQUEST['s'] ) ? wp_unslash( trim( $_REQUEST['s'] ) ) : '';
@@ -57 +56 @@
 
         if ( $role === 'super' ) {
-            $logins          = implode( "', '", get_super_admins() );
-            $args['include'] = $wpdb->get_col( "SELECT ID FROM $wpdb->users WHERE user_login IN ('$logins')" );
+            $args['login__in'] = get_super_admins();
         }