Changeset 44818 for trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss

Timestamp:

03/07/2019 10:36:58 PM (2 years ago)

Author:

allancole

Message:

Twenty Nineteen: Improve custom color behavior for InnerBlocks

Currently, if a parent block has a custom background color assigned, its child blocks will inherit the parent's text colors — even if the child block has its own custom text color assigned to it.

This update changes the following:

• Adjusts Twenty Nineteen's custom background color defaults to target direct children only which fixes the issue

Props kjellr.

See #46432.

File:

• trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss (modified) (6 diffs)

trunk/src/wp-content/themes/twentynineteen/sass/blocks/_blocks.scss

@@ -839 +839 @@
         color: $color__background-body;
 
-        p,
-        h1,
-        h2,
-        h3,
-        h4,
-        h5,
-        h6,
-        a {
+        > p,
+        > h1,
+        > h2,
+        > h3,
+        > h4,
+        > h5,
+        > h6,
+        > a {
             color: $color__background-body;
         }
@@ -855 +855 @@
 
         // Use dark gray text against this background by default.
-        p,
-        h1,
-        h2,
-        h3,
-        h4,
-        h5,
-        h6,
-        a {
+        > p,
+        > h1,
+        > h2,
+        > h3,
+        > h4,
+        > h5,
+        > h6,
+        > a {
             color: $color__text-main;
         }
@@ -895 +895 @@
     .has-primary-color,
     .wp-block-pullquote.is-style-solid-color blockquote.has-primary-color,
-    .wp-block-pullquote.is-style-solid-color blockquote.has-primary-color p {
+    .wp-block-pullquote.is-style-solid-color blockquote.has-primary-color > p {
         color: $color__link;
     }
@@ -901 +901 @@
     .has-secondary-color,
     .wp-block-pullquote.is-style-solid-color blockquote.has-secondary-color,
-    .wp-block-pullquote.is-style-solid-color blockquote.has-secondary-color p {
+    .wp-block-pullquote.is-style-solid-color blockquote.has-secondary-color > p {
         color: $color__border-link-hover;
     }
@@ -907 +907 @@
     .has-dark-gray-color,
     .wp-block-pullquote.is-style-solid-color blockquote.has-dark-gray-color,
-    .wp-block-pullquote.is-style-solid-color blockquote.has-dark-gray-color p {
+    .wp-block-pullquote.is-style-solid-color blockquote.has-dark-gray-color > p {
         color: $color__text-main;
     }
@@ -913 +913 @@
     .has-light-gray-color,
     .wp-block-pullquote.is-style-solid-color blockquote.has-light-gray-color,
-    .wp-block-pullquote.is-style-solid-color blockquote.has-light-gray-color p {
+    .wp-block-pullquote.is-style-solid-color blockquote.has-light-gray-color > p {
         color: $color__text-light;
     }