Changeset 44903 for trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-thing.php

Timestamp:

03/15/2019 12:15:08 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Build/Test Tools: Add missing access modifiers to factory classes in phpunit/includes/factory.

Props andizer.
Fixes #46504.

File:

• trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-thing.php (modified) (12 diffs)

trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-thing.php

@@ -6 +6 @@
 abstract class WP_UnitTest_Factory_For_Thing {
 
-    var $default_generation_definitions;
-    var $factory;
+    public $default_generation_definitions;
+    public $factory;
 
     /**
@@ -17 +17 @@
      * {@link WP_UnitTest_Generator_Locale_Name}, {@link WP_UnitTest_Factory_Callback_After_Create}.
      */
-    function __construct( $factory, $default_generation_definitions = array() ) {
+    public function __construct( $factory, $default_generation_definitions = array() ) {
         $this->factory                        = $factory;
         $this->default_generation_definitions = $default_generation_definitions;
@@ -29 +29 @@
      * @return mixed The result. Can be anything.
      */
-    abstract function create_object( $args );
+    abstract public function create_object( $args );
 
     /**
@@ -39 +39 @@
      * @return mixed The result. Can be anything.
      */
-    abstract function update_object( $object, $fields );
+    abstract public function update_object( $object, $fields );
 
     /**
@@ -49 +49 @@
      * @return mixed The result. Can be anything.
      */
-    function create( $args = array(), $generation_definitions = null ) {
+    public function create( $args = array(), $generation_definitions = null ) {
         if ( is_null( $generation_definitions ) ) {
             $generation_definitions = $this->default_generation_definitions;
@@ -78 +78 @@
      * @return mixed The created object. Can be anything.
      */
-    function create_and_get( $args = array(), $generation_definitions = null ) {
+    public function create_and_get( $args = array(), $generation_definitions = null ) {
         $object_id = $this->create( $args, $generation_definitions );
         return $this->get_object_by_id( $object_id );
@@ -90 +90 @@
      * @return mixed The object. Can be anything.
      */
-    abstract function get_object_by_id( $object_id );
+    abstract public function get_object_by_id( $object_id );
 
     /**
@@ -101 +101 @@
      * @return array
      */
-    function create_many( $count, $args = array(), $generation_definitions = null ) {
+    public function create_many( $count, $args = array(), $generation_definitions = null ) {
         $results = array();
         for ( $i = 0; $i < $count; $i++ ) {
@@ -119 +119 @@
      * @return array|WP_Error Combined array on success. WP_Error when default value is incorrent.
      */
-    function generate_args( $args = array(), $generation_definitions = null, &$callbacks = null ) {
+    public function generate_args( $args = array(), $generation_definitions = null, &$callbacks = null ) {
         $callbacks = array();
         if ( is_null( $generation_definitions ) ) {
@@ -156 +156 @@
      * @return array The altered fields.
      */
-    function apply_callbacks( $callbacks, $created ) {
+    public function apply_callbacks( $callbacks, $created ) {
         $updated_fields = array();
 
@@ -172 +172 @@
      * @return WP_UnitTest_Factory_Callback_After_Create
      */
-    function callback( $function ) {
+    public function callback( $function ) {
         return new WP_UnitTest_Factory_Callback_After_Create( $function );
     }
@@ -183 +183 @@
      * @return array|string The value with the possibly applied slashes.
      */
-    function addslashes_deep( $value ) {
+    public function addslashes_deep( $value ) {
         if ( is_array( $value ) ) {
             $value = array_map( array( $this, 'addslashes_deep' ), $value );