Changeset 44905 for trunk/src/wp-admin/includes/ms.php

Timestamp:

03/15/2019 02:53:18 PM (3 years ago)

Author:

afercia

Message:

Accessibility: Improve the semantics of "tabs" that are not real ARIA tabs.

Some "visual tabs" in the WordPress admin used links wrapped in a h2 heading. While these tabs look like ARIA tabs, they're just navigation menus and should be marked-up as such to be correctly exposed to assistive technologies.

• changes the wrapping <h2> to a <nav> element: worth reminding <nav> elements also define ARIA landmarks
• adds an aria-label to the <nav> elements so they can be distinguished from other <nav> elements in the page
• adjusts the headings level in the Credits page

Props audrasjb, afercia.
Fixes #43398.

File:

• trunk/src/wp-admin/includes/ms.php (modified) (1 diff)

trunk/src/wp-admin/includes/ms.php

@@ -1131 +1131 @@
 
     // All done!
-    echo '<h2 class="nav-tab-wrapper wp-clearfix">';
+    echo '<nav class="nav-tab-wrapper wp-clearfix" aria-label="' . esc_attr__( 'Secondary menu' ) . '">';
     echo implode( '', $screen_links );
-    echo '</h2>';
+    echo '</nav>';
 }