Changeset 44905 for trunk/src/wp-admin/nav-menus.php

Timestamp:

03/15/2019 02:53:18 PM (6 years ago)

Author:

afercia

Message:

Accessibility: Improve the semantics of "tabs" that are not real ARIA tabs.

Some "visual tabs" in the WordPress admin used links wrapped in a h2 heading. While these tabs look like ARIA tabs, they're just navigation menus and should be marked-up as such to be correctly exposed to assistive technologies.

• changes the wrapping <h2> to a <nav> element: worth reminding <nav> elements also define ARIA landmarks
• adds an aria-label to the <nav> elements so they can be distinguished from other <nav> elements in the page
• adjusts the headings level in the Credits page

Props audrasjb, afercia.
Fixes #43398.

File:

• trunk/src/wp-admin/nav-menus.php (modified) (2 diffs)

trunk/src/wp-admin/nav-menus.php

@@ -628 +628 @@
     <hr class="wp-header-end">
 
-    <h2 class="nav-tab-wrapper wp-clearfix">
+    <nav class="nav-tab-wrapper wp-clearfix" aria-label="<?php esc_attr_e( 'Secondary menu' ); ?>">
         <a href="<?php echo admin_url( 'nav-menus.php' ); ?>" class="nav-tab<?php echo $nav_tab_active_class; ?>"><?php esc_html_e( 'Edit Menus' ); ?></a>
         <?php
@@ -641 +641 @@
         }
         ?>
-    </h2>
+    </nav>
     <?php
     foreach ( $messages as $message ) :