Changeset 44918

Timestamp:

03/16/2019 03:21:25 PM (6 years ago)

Author:

afercia

Message:

Accessibility: Login: Display error messages when both the username and password fields are empty.

For accessibility and usability, if an input error is detected, the item that is in error needs to be identified and the error needs to be described to the user in text (WCAG Success Criterion 3.3.1). The login form displays an error when the username field is empty or when the password field is empty. It omits to do so when both fields are empty.

This change restores the login form behavior to the one that used to work in WordPress 2.3 (!) and displays the related error messages also when both fields are empty.

Props birgire, audrasjb.
See #8938, #5405, #3708.
Fixes #42985.

Location:

trunk/src

Files:

• wp-includes/user.php (modified) (1 diff)
• wp-login.php (modified) (1 diff)

trunk/src/wp-includes/user.php

@@ -96 +96 @@
 
     if ( is_wp_error( $user ) ) {
-        if ( $user->get_error_codes() == array( 'empty_username', 'empty_password' ) ) {
-            $user = new WP_Error( '', '' );
-        }
-
         return $user;
     }

trunk/src/wp-login.php

@@ -1008 +1008 @@
         }
 
+        if ( empty( $_POST ) && $errors->get_error_codes() === array( 'empty_username', 'empty_password' ) ) {
+            $errors = new WP_Error( '', '' );
+        }
+
         if ( $interim_login ) {
             if ( ! $errors->has_errors() ) {