Changeset 44924 for trunk/src/wp-admin/includes/dashboard.php

Timestamp:

03/18/2019 03:21:17 PM (8 years ago)

Author:

afercia

Message:

Accessibility: Improve the Comments and Privacy count text.

• standardizes the Comment count string to %s Comment in moderation', '%s Comments in moderation so it can be bulk-updated
• adds the string as visually hidden text in the admin menu
• introduces an updateInModerationText JS simple function, responsible to correctly update all the related text using the data from the AJAX response
• adds a visually hidden text "1 Privacy Policy update" to the Privacy menu items count
• adds/improves translators comments

Changes that apply to all the count bubbles (Updates, plugins, etc.)

• makes the bubbles and their text slightly bigger
• improves the active menu item bubble contrast by changing the background color to red (option 2 in the screenshot attached in a previous comment)

Props adamsoucie, afercia.
Fixes #33030.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (2 diffs)

trunk/src/wp-admin/includes/dashboard.php

@@ -292 +292 @@
                 $moderated_comments_count_i18n = number_format_i18n( $num_comm->moderated );
                 /* translators: %s: number of comments in moderation */
-                $text = sprintf( _nx( '%s in moderation', '%s in moderation', $num_comm->moderated, 'comments' ), $moderated_comments_count_i18n );
-                /* translators: %s: number of comments in moderation */
-                $aria_label = sprintf( _nx( '%s comment in moderation', '%s comments in moderation', $num_comm->moderated, 'comments' ), $moderated_comments_count_i18n );
+                $text = sprintf( _n( '%s Comment in moderation', '%s Comments in moderation', $num_comm->moderated ), $moderated_comments_count_i18n );
                 ?>
                 <li class="comment-mod-count
@@ -302 +300 @@
                 }
                 ?>
-                "><a href="edit-comments.php?comment_status=moderated" aria-label="<?php echo esc_attr( $aria_label ); ?>"><?php echo $text; ?></a></li>
+                "><a href="edit-comments.php?comment_status=moderated" class="comments-in-moderation-text"><?php echo $text; ?></a></li>
                 <?php
         }