Changeset 44933 for trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

Timestamp:

03/19/2019 03:21:28 AM (6 years ago)

Author:

kadamwhite

Message:

REST API: Ensure "Allow" header is returned for OPTIONS requests.

This changeset ensures $request->set_url_params() is called while fulfilling OPTIONS requests, where previously it was skipped because OPTIONS requests short-circuit the logic in dispatch which handles this setup for other request methods. Omitting the URL parameters prevented the Allow header from being set.

Props killua99, noisysocks.
Fixes #45753.

File:

• trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -207 +207 @@
         sort( $keys );
         $this->assertEquals( array( 'context', 'id' ), $keys );
+    }
+
+    /**
+     * @ticket 43701
+     */
+    public function test_allow_header_sent_on_options_request() {
+        $id1      = $this->factory->attachment->create_object(
+            $this->test_file,
+            0,
+            array(
+                'post_mime_type' => 'image/jpeg',
+                'post_excerpt'   => 'A sample caption',
+            )
+        );
+        $request  = new WP_REST_Request( 'OPTIONS', sprintf( '/wp/v2/media/%d', $id1 ) );
+        $response = rest_get_server()->dispatch( $request );
+        $response = apply_filters( 'rest_post_dispatch', $response, rest_get_server(), $request );
+        $headers  = $response->get_headers();
+
+        $this->assertNotEmpty( $headers['Allow'] );
+        $this->assertEquals( $headers['Allow'], 'GET' );
+
+        wp_set_current_user( self::$editor_id );
+        $request  = new WP_REST_Request( 'OPTIONS', sprintf( '/wp/v2/media/%d', $id1 ) );
+        $response = rest_get_server()->dispatch( $request );
+        $response = apply_filters( 'rest_post_dispatch', $response, rest_get_server(), $request );
+        $headers  = $response->get_headers();
+
+        $this->assertNotEmpty( $headers['Allow'] );
+        $this->assertEquals( $headers['Allow'], 'GET, POST, PUT, PATCH, DELETE' );
     }