Changeset 44943

Timestamp:

03/20/2019 05:40:17 PM (7 years ago)

Author:

desrosj

Message:

Tests: Fix failing tests for privacy export/erase requests when running the ajax group for multisite.

Props davidbinda, garrett-eclipse.
Fixes #43438.

Location:

trunk/tests/phpunit/tests/ajax

Files:

• PrivacyErasePersonalData.php (modified) (3 diffs)
• PrivacyExportPersonalData.php (modified) (3 diffs)

trunk/tests/phpunit/tests/ajax/PrivacyErasePersonalData.php

@@ -141 +141 @@
 
                 $this->_setRole( 'administrator' );
+                // erase_others_personal_data meta cap in Multisite installation is only granted to those with `manage_network` capability.
+                if ( is_multisite() ) {
+                        grant_super_admin( get_current_user_id() );
+                }
         }
 
@@ -149 +153 @@
                 remove_filter( 'wp_privacy_personal_data_erasers', array( $this, 'register_custom_personal_data_eraser' ) );
                 $this->new_callback_value = '';
+
+                if ( is_multisite() ) {
+                        revoke_super_admin( get_current_user_id() );
+                }
 
                 parent::tearDown();
@@ -295 +303 @@
                 $this->assertFalse( current_user_can( 'erase_others_personal_data' ) );
                 $this->assertFalse( current_user_can( 'delete_users' ) );
+
+                $this->_make_ajax_call();
+
+                $this->assertFalse( $this->_last_response_parsed['success'] );
+                $this->assertSame( 'Sorry, you are not allowed to perform this action.', $this->_last_response_parsed['data'] );
+        }
+
+        /**
+         * Test requests do not succeed on multisite when the current user is not a network admin.
+         *
+         * @group multisite
+         *
+         * @ticket 43438
+         */
+        public function test_error_when_current_user_missing_required_capabilities_multisite() {
+                if ( ! is_multisite() ) {
+                        $this->markTestSkipped( 'This test only runs on multisite.' );
+                }
+
+                revoke_super_admin( get_current_user_id() );
 
                 $this->_make_ajax_call();

trunk/tests/phpunit/tests/ajax/PrivacyExportPersonalData.php

@@ -155 +155 @@
 
                 $this->_setRole( 'administrator' );
+                // export_others_personal_data meta cap in Multisite installation is only granted to those with `manage_network` capability.
+                if ( is_multisite() ) {
+                        grant_super_admin( get_current_user_id() );
+                }
         }
 
@@ -163 +167 @@
                 remove_filter( 'wp_privacy_personal_data_exporters', array( $this, 'filter_register_custom_personal_data_exporter' ) );
 
+                if ( is_multisite() ) {
+                        revoke_super_admin( get_current_user_id() );
+                }
                 parent::tearDown();
         }
@@ -261 +268 @@
                 $this->assertFalse( $this->_last_response_parsed['success'] );
                 $this->assertFalse( current_user_can( 'export_others_personal_data' ) );
+                $this->assertSame( 'Sorry, you are not allowed to perform this action.', $this->_last_response_parsed['data'] );
+        }
+
+        /**
+         * Test requests do not succeed on multisite when the current user is not a network admin.
+         *
+         * @group multisite
+         *
+         * @ticket 43438
+         */
+        public function test_error_when_current_user_missing_required_capability_multisite() {
+                if ( ! is_multisite() ) {
+                        $this->markTestSkipped( 'This test only runs on multisite.' );
+                }
+
+                revoke_super_admin( get_current_user_id() );
+
+                $this->_make_ajax_call();
+
+                $this->assertFalse( $this->_last_response_parsed['success'] );
                 $this->assertSame( 'Sorry, you are not allowed to perform this action.', $this->_last_response_parsed['data'] );
         }