Changeset 44948 for trunk/src/wp-includes/feed-rss2-comments.php

Timestamp:

03/20/2019 08:37:02 PM (5 years ago)

Author:

adamsilverstein

Message:

Feeds: ensure build/update date matches current query.

Displaying the correct build date in feeds is as important today as it was twelve years ago when this ticket was opened.

Fix an issue where all feeds in WordPress showed the same date for their last build date (the datapoint is lastBuildDate, updated or dc:date depending on the feed type).

Introduce a new get_last_build_date filter to adjust the date used for lastBuildDate. Developers who previously filtered get_lastcommentmodified to alter feed dates should use this filter instead.

• get_last_build_date extracts the latest post (or comment) in the current WP_Query object.
• In all feed templates, use get_last_build_date vs get_lastpostmodified( 'GMT' );.

Props stevenkword, spacedmonkey, ryanshoover, mauteri, nacin, jorbin, MikeNGarrett, Denis-de-Bernardy, peaceablewhale.
Fixes #4575.

File:

• trunk/src/wp-includes/feed-rss2-comments.php (modified) (1 diff)

trunk/src/wp-includes/feed-rss2-comments.php

@@ -52 +52 @@
     <lastBuildDate>
     <?php
-        $date = get_lastcommentmodified( 'GMT' );
+        $date = get_last_build_date();
         echo $date ? mysql2date( 'r', $date, false ) : date( 'r' );
     ?>