Changeset 44959

Timestamp:

03/21/2019 12:43:48 PM (6 years ago)

Author:

desrosj

Message:

Posts, Post Types: Add type parameter to post_exists().

This allows post exists checks scoped to a specific post type.

Props sgarza, birgire, swissspidy.
Fixes #37406.

Location:

trunk

Files:

• src/wp-admin/includes/post.php (modified) (3 diffs)
• tests/phpunit/tests/admin/includesPost.php (modified) (1 diff)

trunk/src/wp-admin/includes/post.php

@@ -732 +732 @@
 
 /**
- * Determine if a post exists based on title, content, and date
+ * Determines if a post exists based on title, content, date and type.
  *
  * @since 2.0.0
+ * @since 5.2.0 Added the `$type` parameter.
  *
  * @global wpdb $wpdb WordPress database abstraction object.
  *
- * @param string $title Post title
- * @param string $content Optional post content
- * @param string $date Optional post date
+ * @param string $title   Post title.
+ * @param string $content Optional post content.
+ * @param string $date    Optional post date.
+ * @param string $type    Optional post type.
  * @return int Post ID if post exists, 0 otherwise.
  */
-function post_exists( $title, $content = '', $date = '' ) {
+function post_exists( $title, $content = '', $date = '', $type = '' ) {
     global $wpdb;
 
@@ -749 +751 @@
     $post_content = wp_unslash( sanitize_post_field( 'post_content', $content, 0, 'db' ) );
     $post_date    = wp_unslash( sanitize_post_field( 'post_date', $date, 0, 'db' ) );
+    $post_type    = wp_unslash( sanitize_post_field( 'post_type', $type, 0, 'db' ) );
 
     $query = "SELECT ID FROM $wpdb->posts WHERE 1=1";
@@ -766 +769 @@
         $query .= ' AND post_content = %s';
         $args[] = $post_content;
+    }
+
+    if ( ! empty( $type ) ) {
+        $query .= ' AND post_type = %s';
+        $args[] = $post_type;
     }
 

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -852 +852 @@
         $this->assertEquals( '', get_post_meta( $p, 'testkey', true ) );
     }
+
+    /**
+     * Test the post type support in post_exists().
+     *
+     * @ticket 37406
+     */
+    public function test_post_exists_should_support_post_type() {
+        $title     = 'Foo Bar';
+        $post_type = 'page';
+        $post_id   = self::factory()->post->create(
+            array(
+                'post_title' => $title,
+                'post_type'  => $post_type,
+            )
+        );
+        $this->assertSame( $post_id, post_exists( $title, null, null, $post_type ) );
+    }
+
+    /**
+     * Test that post_exists() doesn't find an existing page as a post.
+     *
+     * @ticket 37406
+     */
+    public function test_post_exists_should_not_match_a_page_for_post() {
+        $title     = 'Foo Bar';
+        $post_type = 'page';
+        $post_id   = self::factory()->post->create(
+            array(
+                'post_title' => $title,
+                'post_type'  => $post_type,
+            )
+        );
+        $this->assertSame( 0, post_exists( $title, null, null, 'post' ) );
+    }
 }