Changeset 44965 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

Timestamp:

03/21/2019 06:58:50 PM (6 years ago)

Author:

kadamwhite

Message:

REST API: Avoid undefined-property notice when setting parent term to 0.

Only try to access term_id once $parent_term is known to be a WP_Term.

Props dlh, earnjam.
Fixes #44983.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

@@ -686 +686 @@
 
         if ( isset( $request['parent'] ) && ! empty( $schema['properties']['parent'] ) ) {
-            $parent_term_id = 0;
-            $parent_term    = get_term( (int) $request['parent'], $this->taxonomy );
-
-            if ( $parent_term ) {
-                $parent_term_id = $parent_term->term_id;
+            $parent_term_id   = 0;
+            $requested_parent = (int) $request['parent'];
+
+            if ( $requested_parent ) {
+                $parent_term = get_term( $requested_parent, $this->taxonomy );
+
+                if ( $parent_term instanceof WP_Term ) {
+                    $parent_term_id = $parent_term->term_id;
+                }
             }