Changeset 45028 for trunk/tests/phpunit/tests/general/template.php

Timestamp:

03/27/2019 12:15:15 PM (8 years ago)

Author:

SergeyBiryukov

Message:

Themes: Remove itemprop="url" from get_custom_logo() output.

Making incorrect assumptions about microdata used in a theme results in invalid markup.

The attribute can still be added using the get_custom_logo or wp_get_attachment_image_attributes filter, but it should not be added by default.

Props henry.wright, tfrommen, afercia, markcallen, zodiac1978.
Fixes #37305.

File:

• trunk/tests/phpunit/tests/general/template.php (modified) (5 diffs)

trunk/tests/phpunit/tests/general/template.php

@@ -309 +309 @@
 
                 $custom_logo_attr = array(
-                        'class'    => 'custom-logo',
-                        'itemprop' => 'logo',
+                        'class' => 'custom-logo',
                 );
 
@@ -323 +322 @@
                 restore_current_blog();
 
-                $expected_custom_logo = '<a href="' . $home_url . '" class="custom-logo-link" rel="home" itemprop="url">' . $image . '</a>';
+                $expected_custom_logo = '<a href="' . $home_url . '" class="custom-logo-link" rel="home">' . $image . '</a>';
                 $this->assertEquals( $expected_custom_logo, get_custom_logo( $blog_id ) );
         }
@@ -339 +338 @@
 
                 $custom_logo_attr = array(
-                        'class'    => 'custom-logo',
-                        'itemprop' => 'logo',
+                        'class' => 'custom-logo',
                 );
 
@@ -351 +349 @@
                 $image = wp_get_attachment_image( $this->custom_logo_id, 'full', false, $custom_logo_attr );
 
-                $this->expectOutputString( '<a href="http://' . WP_TESTS_DOMAIN . '/" class="custom-logo-link" rel="home" itemprop="url">' . $image . '</a>' );
+                $this->expectOutputString( '<a href="http://' . WP_TESTS_DOMAIN . '/" class="custom-logo-link" rel="home">' . $image . '</a>' );
                 the_custom_logo();
         }
@@ -371 +369 @@
                         false,
                         array(
-                                'class'    => 'custom-logo',
-                                'itemprop' => 'logo',
+                                'class' => 'custom-logo',
                         )
                 );
 
-                $this->expectOutputString( '<a href="http://' . WP_TESTS_DOMAIN . '/" class="custom-logo-link" rel="home" itemprop="url">' . $image . '</a>' );
+                $this->expectOutputString( '<a href="http://' . WP_TESTS_DOMAIN . '/" class="custom-logo-link" rel="home">' . $image . '</a>' );
                 the_custom_logo();
         }