Changeset 45046

Timestamp:

03/27/2019 11:05:00 PM (5 years ago)

Author:

pento

Message:

Upgrades: Allow upgrades to proceed when a soft failure occurs on package signatures.

In particular, this allows downgrading from WordPress 5.2 to 5.1.1, if sites wish to opt out of the beta.

Props dd32.
See #46615.

File:

• trunk/src/wp-admin/includes/class-core-upgrader.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-core-upgrader.php

@@ -123 +123 @@
 
         $download = $this->download_package( $current->packages->$to_download );
+
+        // Allow for signature soft-fail.
+        // WARNING: This may be removed in the future.
+        if ( is_wp_error( $download ) && $download->get_error_data( 'softfail-filename' ) ) {
+            // Outout the failure error as a normal feedback, and not as an error:
+            apply_filters( 'update_feedback', $download->get_error_message() );
+
+            // Report this failure back to WordPress.org for debugging purposes.
+            wp_version_check(
+                array(
+                    'signature_failure_code' => $download->get_error_code(),
+                    'signature_failure_data' => $download->get_error_data(),
+                )
+            );
+
+            // Pretend this error didn't happen.
+            $download = $download->get_error_data( 'softfail-filename' );
+        }
+
         if ( is_wp_error( $download ) ) {
             WP_Upgrader::release_lock( 'core_updater' );