Changeset 45064

Timestamp:

03/28/2019 09:58:45 PM (7 years ago)

Author:

johnbillion

Message:

Options, Meta APIs: Ensure the $object_id parameter passed to the delete_{$meta_type}_meta and deleted_{$meta_type}_meta filters is always an integer.

Props salcode

Fixes #43561

Location:

trunk

Files:

• src/wp-includes/meta.php (modified) (1 diff)
• tests/phpunit/tests/meta/deleteMetadata.php (modified) (1 diff)

trunk/src/wp-includes/meta.php

@@ -813 +813 @@
         // Fetch the meta and go on if it's found.
         if ( $meta = get_metadata_by_mid( $meta_type, $meta_id ) ) {
-                $object_id = $meta->{$column};
+                $object_id = (int) $meta->{$column};
 
                 /** This action is documented in wp-includes/meta.php */

trunk/tests/phpunit/tests/meta/deleteMetadata.php

@@ -145 +145 @@
                 $this->assertFalse( $p2_cache );
         }
+
+        /**
+         * @ticket 43561
+         */
+        public function test_object_id_is_int_inside_delete_post_meta() {
+                $post_id = self::factory()->post->create();
+                $meta_id = add_metadata( 'post', $post_id, 'my_key', 'my_value' );
+                add_action( 'delete_post_meta', [ $this, 'action_check_object_id_is_int' ], 10, 2 );
+                delete_metadata_by_mid( 'post', $meta_id );
+        }
+
+        public function action_check_object_id_is_int( $meta_type, $object_id ) {
+                $this->assertEquals(
+                        'integer',
+                        gettype( $object_id )
+                );
+        }
 }