Changeset 45076 for trunk/src/wp-admin/site-health.php

Timestamp:

03/30/2019 03:37:28 PM (7 years ago)

Author:

afercia

Message:

Administration: Display a notice in the Site Health pages when JavaScript is off.

• displays an error notice when JavaScript is off, consistently with other admin screens that depend on JavaScript
• keeps the main h1 visible

Minor clean-ups:

• makes code indentation consistent in site-health.php and site-health-info.php
• removes a couple of <div class="wp-clearfix"></div> as that's not the intended usage of wp-clearfix (those divs didn't do anything anyways)

Fixes #46717.

File:

• trunk/src/wp-admin/site-health.php (modified) (4 diffs)

trunk/src/wp-admin/site-health.php

@@ -35 +35 @@
 require_once( ABSPATH . 'wp-admin/admin-header.php' );
 ?>
-
 <div class="health-check-header">
         <div class="health-check-title-section">
@@ -42 +41 @@
                 </h1>
 
-                <div class="site-health-progress loading">
+                <div class="site-health-progress hide-if-no-js loading">
                         <svg role="img" aria-hidden="true" focusable="false" width="100%" height="100%" viewBox="0 0 200 200" version="1.1" xmlns="http://www.w3.org/2000/svg">
                                 <circle r="90" cx="100" cy="100" fill="transparent" stroke-dasharray="565.48" stroke-dashoffset="0"></circle>
@@ -52 +51 @@
         </div>
 
-        <nav class="health-check-tabs-wrapper" aria-label="<?php esc_attr_e( 'Secondary menu' ); ?>">
+        <nav class="health-check-tabs-wrapper hide-if-no-js" aria-label="<?php esc_attr_e( 'Secondary menu' ); ?>">
                 <a href="<?php echo esc_url( admin_url( 'site-health.php' ) ); ?>" class="health-check-tab active" aria-current="true">
                         <?php _e( 'Status' ); ?>
@@ -61 +60 @@
                 </a>
         </nav>
-
-        <div class="wp-clearfix"></div>
 </div>
 
-<div class="health-check-body">
+<div class="notice notice-error hide-if-js">
+        <p><?php _e( 'The Site Health check requires JavaScript.' ); ?></p>
+</div>
+
+<div class="health-check-body hide-if-no-js">
         <div class="site-status-all-clear hide">
                 <p class="icon">