Changeset 45087

Timestamp:

04/01/2019 03:07:30 PM (7 years ago)

Author:

afercia

Message:

Accessibility: Improve the Site Health accordions.

• removes the definition list and uses the markup from the ARIA Authoring Practices example
• removes incorrect ARIA roles
• avoids ARIA landmark regions proliferation

Props mukesh27 for the initial patch.
Fixes #46714.

Location:

trunk/src/wp-admin

Files:

• css/site-health.css (modified) (1 diff)
• site-health-info.php (modified) (3 diffs)
• site-health.php (modified) (3 diffs)

trunk/src/wp-admin/css/site-health.css

@@ -272 +272 @@
 }
 
-.health-check-accordion dt {
-        font-weight: 600;
+.health-check-accordion-heading {
+        margin: 0;
         border-top: 1px solid #e2e4e7;
-}
-
-.health-check-accordion dt:first-child {
+        font-size: inherit;
+        line-height: inherit;
+        font-weight: 600;
+        color: inherit;
+}
+
+.health-check-accordion-heading:first-child {
         border-top: none;
 }

trunk/src/wp-admin/site-health-info.php

@@ -96 +96 @@
         </div>
 
-        <dl id="health-check-debug" role="presentation" class="health-check-accordion">
+        <div id="health-check-debug" class="health-check-accordion">
 
                 <?php
@@ -104 +104 @@
                         }
                         ?>
-                        <dt role="heading" aria-level="3">
-                                <button aria-expanded="false" class="health-check-accordion-trigger" aria-controls="health-check-accordion-block-<?php echo esc_attr( $section ); ?>" id="health-check-accordion-heading-<?php echo esc_attr( $section ); ?>" type="button">
-                <span class="title">
-                        <?php echo esc_html( $details['label'] ); ?>
+                        <h3 class="health-check-accordion-heading">
+                                <button aria-expanded="false" class="health-check-accordion-trigger" aria-controls="health-check-accordion-block-<?php echo esc_attr( $section ); ?>" type="button">
+                                        <span class="title">
+                                                <?php echo esc_html( $details['label'] ); ?>
 
-                        <?php if ( isset( $details['show_count'] ) && $details['show_count'] ) : ?>
-                                <?php printf( '(%d)', count( $details['fields'] ) ); ?>
-                        <?php endif; ?>
-                </span>
+                                                <?php if ( isset( $details['show_count'] ) && $details['show_count'] ) : ?>
+                                                        <?php printf( '(%d)', count( $details['fields'] ) ); ?>
+                                                <?php endif; ?>
+                                        </span>
                                         <span class="icon"></span>
                                 </button>
-                        </dt>
+                        </h3>
 
-                        <dd id="health-check-accordion-block-<?php echo esc_attr( $section ); ?>" role="region" aria-labelledby="health-check-accordion-heading-<?php echo esc_attr( $section ); ?>" class="health-check-accordion-panel" hidden="hidden">
+                        <div id="health-check-accordion-block-<?php echo esc_attr( $section ); ?>" class="health-check-accordion-panel" hidden="hidden">
                                 <?php
                                 if ( isset( $details['description'] ) && ! empty( $details['description'] ) ) {
@@ -162 +162 @@
                                         </tbody>
                                 </table>
-                        </dd>
+                        </div>
                 <?php } ?>
-        </dl>
+        </div>
 </div>
 

trunk/src/wp-admin/site-health.php

@@ -93 +93 @@
                         </h3>
 
-                        <dl id="health-check-site-status-critical" role="presentation" class="health-check-accordion issues"></dl>
+                        <div id="health-check-site-status-critical" class="health-check-accordion issues"></div>
                 </div>
 
@@ -101 +101 @@
                         </h3>
 
-                        <dl id="health-check-site-status-recommended" role="presentation" class="health-check-accordion issues"></dl>
+                        <div id="health-check-site-status-recommended" class="health-check-accordion issues"></div>
                 </div>
         </div>
@@ -116 +116 @@
                 </h3>
 
-                <dl id="health-check-site-status-good" role="presentation" class="health-check-accordion issues"></dl>
+                <div id="health-check-site-status-good" class="health-check-accordion issues"></div>
         </div>
 </div>
 
 <script id="tmpl-health-check-issue" type="text/template">
-        <dt role="heading" aria-level="4">
-                <button aria-expanded="false" class="health-check-accordion-trigger" aria-controls="health-check-accordion-block-{{ data.test }}" id="health-check-accordion-heading-{{ data.test }}" type="button">
+        <h4 class="health-check-accordion-heading">
+                <button aria-expanded="false" class="health-check-accordion-trigger" aria-controls="health-check-accordion-block-{{ data.test }}" type="button">
                         <span class="title">{{ data.label }}</span>
                         <span class="badge {{ data.badge.color }}">{{ data.badge.label }}</span>
                         <span class="icon"></span>
                 </button>
-        </dt>
-        <dd id="health-check-accordion-block-{{ data.test }}" aria-labelledby="health-check-accordion-heading-{{ data.test }}" role="region" class="health-check-accordion-panel" hidden="hidden">
+        </h4>
+        <div id="health-check-accordion-block-{{ data.test }}" class="health-check-accordion-panel" hidden="hidden">
                 {{{ data.description }}}
                 <div class="actions">
                         <p class="button-container">{{{ data.actions }}}</p>
                 </div>
-        </dd>
+        </div>
 </script>