Changeset 45100 for trunk/src/wp-includes/widgets/class-wp-widget-media-image.php

Timestamp:

04/02/2019 10:12:11 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema filter are not overridden by subclasses.

Previously, WP_Widget_Media_Audio, WP_Widget_Media_Image, and WP_Widget_Media_Video used to override the changes due to reversed arguments in array_merge() call.

Props Toro_Unit, birgire.
Fixes #45029.

File:

• trunk/src/wp-includes/widgets/class-wp-widget-media-image.php (modified) (5 diffs)

trunk/src/wp-includes/widgets/class-wp-widget-media-image.php

@@ -20 +20 @@
      * Constructor.
      *
-     * @since  4.8.0
+     * @since 4.8.0
      */
     public function __construct() {
@@ -54 +54 @@
      * Get schema for properties of a widget instance (item).
      *
-     * @since  4.8.0
+     * @since 4.8.0
      *
      * @see WP_REST_Controller::get_item_schema()
@@ -63 +63 @@
     public function get_instance_schema() {
         return array_merge(
-            parent::get_instance_schema(),
             array(
                 'size'              => array(
@@ -162 +161 @@
                  * - width (redundant when size is not custom)
                  */
-            )
+            ),
+            parent::get_instance_schema()
         );
     }
@@ -169 +169 @@
      * Render the media on the frontend.
      *
-     * @since  4.8.0
+     * @since 4.8.0
      *
      * @param array $instance Widget instance props.