Changeset 45101 for trunk/tests/phpunit/tests/widgets/media-image-widget.php

Timestamp:

04/02/2019 10:14:19 PM (8 years ago)

Author:

SergeyBiryukov

Message:

Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema filter are not overridden by subclasses.

Add unit tests missed in [45100].

Props Toro_Unit, birgire.
See #45029.

File:

• trunk/tests/phpunit/tests/widgets/media-image-widget.php (modified) (2 diffs)

trunk/tests/phpunit/tests/widgets/media-image-widget.php

@@ -35 +35 @@
                 $widget = new WP_Widget_Media_Image();
                 $schema = $widget->get_instance_schema();
-
                 $this->assertEqualSets(
                         array(
@@ -59 +58 @@
 
         /**
+         * Test schema filtering.
+         *
+         * @covers WP_Widget_Media_Image::get_instance_schema
+         *
+         * @ticket 45029
+         */
+        function test_get_instance_schema_filtering() {
+                $widget = new WP_Widget_Media_Image();
+                $schema = $widget->get_instance_schema();
+
+                add_filter( 'widget_media_image_instance_schema', array( $this, 'filter_instance_schema' ), 10, 2 );
+                $schema = $widget->get_instance_schema();
+
+                $this->assertSame( 'large', $schema['size']['default'] );
+        }
+
+        /**
+         * Filters instance schema.
+         *
+         * @since 5.2.0
+         *
+         * @param array                 $schema Schema.
+         * @param WP_Widget_Media_Image $widget Widget.
+         *
+         * @return array
+         */
+        public function filter_instance_schema( $schema, $widget ) {
+                // Override the default size value ('medium').
+                $schema['size']['default'] = 'large';
+                return $schema;
+        }
+
+        /**
          * Test constructor.
          *