Changeset 45121

Timestamp:

04/06/2019 03:59:29 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Update recommendation labels to highlight Performance instead of Security when using a supported and actively maintained version of WordPress, PHP, or MySQL.

Props Clorith, earnjam.
Fixes #46789.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (7 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -183 +183 @@
             'status'      => '',
             'badge'       => array(
-                'label' => __( 'Security' ),
+                'label' => __( 'Performance' ),
                 'color' => 'red',
             ),
@@ -243 +243 @@
                     } else {
                         // This is a minor version, sometimes considered more critical.
-                        $result['status']      = 'critical';
-                        $result['description'] = sprintf(
+                        $result['status']         = 'critical';
+                        $result['badge']['label'] = __( 'Security' );
+                        $result['description']    = sprintf(
                             '<p>%s</p>',
                             __( 'A new minor update is available for your site. Because minor updates often address security, it&#8217;s important to install them.' )
@@ -622 +623 @@
             'status'      => 'good',
             'badge'       => array(
-                'label' => __( 'Security' ),
+                'label' => __( 'Performance' ),
                 'color' => 'red',
             ),
@@ -652 +653 @@
         }
 
-        // The PHP version is only recieving security fixes.
+        // The PHP version is only receiving security fixes.
         if ( $response['is_secure'] ) {
             $result['label']  = __( 'Your PHP version should be updated' );
@@ -661 +662 @@
 
         // Anything no longer secure must be updated.
-        $result['label']  = __( 'Your PHP version requires an update' );
-        $result['status'] = 'critical';
+        $result['label']          = __( 'Your PHP version requires an update' );
+        $result['status']         = 'critical';
+        $result['badge']['label'] = __( 'Security' );
 
         return $result;
@@ -906 +908 @@
             'status'      => 'good',
             'badge'       => array(
-                'label' => __( 'Security' ),
+                'label' => __( 'Performance' ),
                 'color' => 'red',
             ),
@@ -938 +940 @@
             $result['status'] = 'critical';
 
-            $result['label'] = __( 'Severely outdated SQL server' );
+            $result['label']          = __( 'Severely outdated SQL server' );
+            $result['badge']['label'] = __( 'Security' );
 
             $result['description'] .= sprintf(