WordPress.org

Make WordPress Core

Changeset 45148


Ignore:
Timestamp:
04/09/2019 12:03:07 AM (2 weeks ago)
Author:
pento
Message:

Privacy: Only mark a personal data export as complete when the user downloads it.

An admin may download an export to check that it's all correct, but this action shouldn't mark the request as complete.

Props garrett-eclipse, JoshuaWold, birgire.
Fixes #44644.

Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/file.php

    r45112 r45148  
    25512551            wp_send_json_error( $mail_success->get_error_message() );
    25522552        }
     2553
     2554        // Update the request to completed state when the export email is sent.
     2555        _wp_privacy_completed_request( $request_id );
    25532556    } else {
    25542557        // Modify the response to include the URL of the export file so the browser can fetch it.
     
    25592562    }
    25602563
    2561     // Update the request to completed state.
    2562     _wp_privacy_completed_request( $request_id );
    2563 
    25642564    return $response;
    25652565}
  • trunk/tests/phpunit/tests/privacy/wpPrivacyProcessPersonalDataExportPage.php

    r44786 r45148  
    616616    public function data_export_page_status_transitions() {
    617617        return array(
    618             // Mark the request as completed for the last exporter on the last page, with and without email.
     618            // Mark the request as completed for the last exporter on the last page, with email.
    619619            array(
    620620                'request-completed',
     
    625625                'last',
    626626            ),
    627             array(
    628                 'request-completed',
     627            // Leave the request as pending for the last exporter on the last page, without email.
     628            // This check was updated to account for admin vs user export.
     629            // Don't mark the request as completed when it's an admin download.
     630            array(
     631                'request-pending',
    629632                'last',
    630633                'last',
Note: See TracChangeset for help on using the changeset viewer.