Changeset 45198

Timestamp:

04/14/2019 02:29:03 PM (6 years ago)

Author:

afercia

Message:

Site health: Improve jQuery selectors so that they don't depend on a specific markup.

Amends [45178].
See #46683.

Location:

trunk/src

Files:

• js/_enqueues/admin/site-health.js (modified) (1 diff)
• wp-admin/site-health.php (modified) (3 diffs)

trunk/src/js/_enqueues/admin/site-health.js

@@ -73 +73 @@
 
         if ( heading ) {
-            $( '> h3', issueWrapper ).html( heading );
+            $( '.site-health-issue-count-title', issueWrapper ).html( heading );
         }
 

trunk/src/wp-admin/site-health.php

@@ -91 +91 @@
 
         <div class="site-health-issues-wrapper" id="health-check-issues-critical">
-            <h3>
+            <h3 class="site-health-issue-count-title">
                 <?php printf( _n( '%s Critical issue', '%s Critical issues', 0 ), '<span class="issue-count">0</span>' ); ?>
             </h3>
@@ -99 +99 @@
 
         <div class="site-health-issues-wrapper" id="health-check-issues-recommended">
-            <h3>
+            <h3 class="site-health-issue-count-title">
                 <?php printf( _n( '%s Recommended improvement', '%s Recommended improvements', 0 ), '<span class="issue-count">0</span>' ); ?>
             </h3>
@@ -114 +114 @@
 
     <div class="site-health-issues-wrapper hidden" id="health-check-issues-good">
-        <h3>
+        <h3 class="site-health-issue-count-title">
             <?php printf( _n( '%s Item with no issues detected', '%s Items with no issues detected', 0 ), '<span class="issue-count">0</span>' ); ?>
         </h3>