Changeset 45213 for trunk/src/wp-content/themes/twentyseventeen/functions.php

Timestamp:

04/16/2019 02:55:48 PM (5 years ago)

Author:

desrosj

Message:

Bundled Themes: Use the theme version when enqueuing theme specific stylesheets.

For many bundled theme related stylesheets, a version is either not specified, or specified as a hardcoded date string when enqueued. This is problematic when a stylesheet is updated and the version number is not (which has happened several times recently). This change ensures that all bundled theme related stylesheets use the theme’s version as the stylesheet version. This ensures cache busting for theme stylesheets every time a theme is updated and guarantees that users receive any new or updated styles included in the update when visiting the site for the first time after an update.

Props parsmizban, ianbelanger, dswebsme.
Fixes #39997.

File:

• trunk/src/wp-content/themes/twentyseventeen/functions.php (modified) (2 diffs)

trunk/src/wp-content/themes/twentyseventeen/functions.php

@@ -447 +447 @@
 
     // Theme stylesheet.
-    wp_enqueue_style( 'twentyseventeen-style', get_stylesheet_uri() );
+    wp_enqueue_style( 'twentyseventeen-style', get_stylesheet_uri(), array(), wp_get_theme()->get( 'Version' ) );
 
     // Theme block stylesheet.
-    wp_enqueue_style( 'twentyseventeen-block-style', get_theme_file_uri( '/assets/css/blocks.css' ), array( 'twentyseventeen-style' ), '1.1' );
+    wp_enqueue_style( 'twentyseventeen-block-style', get_theme_file_uri( '/assets/css/blocks.css' ), array( 'twentyseventeen-style' ), wp_get_theme()->get( 'Version' ) );
 
     // Load the dark colorscheme.
     if ( 'dark' === get_theme_mod( 'colorscheme', 'light' ) || is_customize_preview() ) {
-        wp_enqueue_style( 'twentyseventeen-colors-dark', get_theme_file_uri( '/assets/css/colors-dark.css' ), array( 'twentyseventeen-style' ), '1.0' );
+        wp_enqueue_style( 'twentyseventeen-colors-dark', get_theme_file_uri( '/assets/css/colors-dark.css' ), array( 'twentyseventeen-style' ), wp_get_theme()->get( 'Version' ) );
     }
 
     // Load the Internet Explorer 9 specific stylesheet, to fix display issues in the Customizer.
     if ( is_customize_preview() ) {
-        wp_enqueue_style( 'twentyseventeen-ie9', get_theme_file_uri( '/assets/css/ie9.css' ), array( 'twentyseventeen-style' ), '1.0' );
+        wp_enqueue_style( 'twentyseventeen-ie9', get_theme_file_uri( '/assets/css/ie9.css' ), array( 'twentyseventeen-style' ), wp_get_theme()->get( 'Version' ) );
         wp_style_add_data( 'twentyseventeen-ie9', 'conditional', 'IE 9' );
     }
 
     // Load the Internet Explorer 8 specific stylesheet.
-    wp_enqueue_style( 'twentyseventeen-ie8', get_theme_file_uri( '/assets/css/ie8.css' ), array( 'twentyseventeen-style' ), '1.0' );
+    wp_enqueue_style( 'twentyseventeen-ie8', get_theme_file_uri( '/assets/css/ie8.css' ), array( 'twentyseventeen-style' ), wp_get_theme()->get( 'Version' ) );
     wp_style_add_data( 'twentyseventeen-ie8', 'conditional', 'lt IE 9' );
 
@@ -508 +508 @@
 function twentyseventeen_block_editor_styles() {
     // Block styles.
-    wp_enqueue_style( 'twentyseventeen-block-editor-style', get_theme_file_uri( '/assets/css/editor-blocks.css' ), array(), '1.1' );
+    wp_enqueue_style( 'twentyseventeen-block-editor-style', get_theme_file_uri( '/assets/css/editor-blocks.css' ), array(), wp_get_theme()->get( 'Version' ) );
     // Add custom fonts.
     wp_enqueue_style( 'twentyseventeen-fonts', twentyseventeen_fonts_url(), array(), null );